[Merge] lp:~ted/ubuntu-dev-tools/create-new-milestone into lp:ubuntu-dev-tools

Michael Vogt michael.vogt at ubuntu.com
Thu Mar 24 13:01:07 UTC 2011


Thanks for this code. The second for loop can probably be written as follow:

+        # Create a new milestone if requested
+        if not new_milestone is None:
+            mil = release.milestone
+            for series in proj.series:
+                if mil.name in [milestone.name for milestone in series.all_milestones]:
+                   series.newMilestone(name=new_milestone)
+                   break

Not a big deal, but makes it slightly shorter.
-- 
https://code.launchpad.net/~ted/ubuntu-dev-tools/create-new-milestone/+merge/54616
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~ted/ubuntu-dev-tools/create-new-milestone into lp:ubuntu-dev-tools.



More information about the Ubuntu-reviews mailing list