[Merge] lp:~csurbhi/mdadm/mdadm-fix.728435 into lp:~ubuntu-core-dev/mdadm/ubuntu

Colin Watson cjwatson at canonical.com
Fri Mar 18 16:17:25 UTC 2011


Review: Needs Fixing
Thanks for your contribution to Ubuntu!

I've updated lp:~ubuntu-core-dev/mdadm/ubuntu to match the current archive.  Please could you merge from that branch, resolve any changelog conflicts, and then re-push to lp:~csurbhi/mdadm/mdadm-fix.728435?  (You don't need to file a new merge proposal - this one will update automatically.)

Secondly, patch files in debian/patches/ should only be used when patching upstream source code.  When changing files in debian/, you should just change them directly rather than with a patch file.  In this case, you should just be able to undo your changes to debian/patches/, since your branch already changes debian/initramfs/init-premount as well.

Finally, there are some confusing typos in the changelog - according to mdadm(8), -r is short for --remove while -R is short for --run.  As such, I think the two mentions of -Ars should be corrected to -ARs, while the mention of -Irs should be corrected to -IRs.
-- 
https://code.launchpad.net/~csurbhi/mdadm/mdadm-fix.728435/+merge/54011
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/mdadm/ubuntu.



More information about the Ubuntu-reviews mailing list