[Merge] lp:~brian-murray/ubuntu/natty/ubuntu-geoip/fix-719324 into lp:ubuntu/ubuntu-geoip

Brian Murray brian at ubuntu.com
Fri Mar 4 22:43:39 UTC 2011


Brian Murray has proposed merging lp:~brian-murray/ubuntu/natty/ubuntu-geoip/fix-719324 into lp:ubuntu/ubuntu-geoip.

Requested reviews:
  Ubuntu Development Team (ubuntu-dev)
Related bugs:
  #719324 ubuntu-geoip-provider should use uppercase HTTP method
  https://bugs.launchpad.net/bugs/719324

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu/natty/ubuntu-geoip/fix-719324/+merge/52268

I created a branch for the patch in bug 719324.  From its description:

According to rfc2616 HTTP request methods are case-sensitive. Currently ubunt-geoip-provider makes an HTTP GET request with a lowercase method name.

Example:
get /lookup HTTP/1.1

Expected:
GET /lookup HTTP/1.1

While web servers (like Apache and Squid) accept the lowercase method name, it may not be the case for some less liberal servers.
-- 
https://code.launchpad.net/~brian-murray/ubuntu/natty/ubuntu-geoip/fix-719324/+merge/52268
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~brian-murray/ubuntu/natty/ubuntu-geoip/fix-719324 into lp:ubuntu/ubuntu-geoip.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1011 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20110304/8bb69610/attachment.diff>


More information about the Ubuntu-reviews mailing list