[Merge] lp:~brian-murray/ubuntu/oneiric/apport/fix-kernel-driver-tagging into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu

Brian Murray brian at ubuntu.com
Fri Jul 22 16:42:46 UTC 2011


Brian Murray has proposed merging lp:~brian-murray/ubuntu/oneiric/apport/fix-kernel-driver-tagging into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/fix-kernel-driver-tagging/+merge/68877

The regex for kernel driver tagging was too specific and only matching EIP and not RIP since RIP messages don't contain 'is at'.  You can see failures in bug 812765 and bug 814460.

Looking at some local kernel oops reports I have:

745213-OopsText.txt:RIP  [<ffffffffa014c745>] v4l2_device_register_subdev+0x95/0x170 [videodev]
748727-OopsText.txt:RIP: 0010:[<ffffffffa00dcd3e>]  [<ffffffffa00dcd3e>] i915_batchbuffer_info+0x10e/0x160 [i915]
751436-OopsText.txt:RIP: 0010:[<ffffffffa0188d3e>]  [<ffffffffa0188d3e>] i915_batchbuffer_info+0x10e/0x160 [i915]
751744-OopsText.txt:RIP: 0010:[<ffffffffa005c433>]  [<ffffffffa005c433>] drm_mode_connector_update_edid_property+0x43/0x1c0 [drm]

so this branch should ensure the oops reports gets tagged properly.
-- 
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/fix-kernel-driver-tagging/+merge/68877
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~brian-murray/ubuntu/oneiric/apport/fix-kernel-driver-tagging into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1080 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20110722/adedc231/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list