[Merge] lp:~brian-murray/ubuntu/oneiric/apport/conffile-handling into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu

[Brian Murray]

Brian Murray has proposed merging lp:~brian-murray/ubuntu/oneiric/apport/conffile-handling into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.

Requested reviews:
  Martin Pitt (pitti)
Related bugs:
  Bug #811203 in apport (Ubuntu Oneiric): "modified conf file contents attached by apport without asking"
  https://bugs.launchpad.net/ubuntu/oneiric/+source/apport/+bug/811203

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/conffile-handling/+merge/68477

This branch raises a yes / no dialog in the event that a conffile is modified so that the reporter can make an informed decision about including the modified conffile.

I'd really rather that ui be a required argument to attach_conffiles so that source package hooks must pass ui to it as its possible the person writing the source package hook isn't familiar with the conffiles provided by the package and their contents.

If need be I'm willing to modify the source package hooks that call attach_conffiles to pass ui and then change the argument so that it no longer defaults to None.
-- 
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/conffile-handling/+merge/68477
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2436 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20110719/96a6f32f/attachment.diff>