[Merge] lp:~brian-murray/ubuntu/oneiric/apport/further-grub-handling into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu
Brian Murray
brian at ubuntu.com
Tue Jul 19 20:19:57 UTC 2011
Brian Murray has proposed merging lp:~brian-murray/ubuntu/oneiric/apport/further-grub-handling into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.
Requested reviews:
Martin Pitt (pitti)
For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/further-grub-handling/+merge/68457
The match_error_messages function of the ubuntu general hook wasn't checking VarLogDistupgradeApttermlog at all which seemed like something worth fixing to me since dist-upgrades are likely to run into the same issues. The easiest way to check multiple files seemed to me to be creating a new function, check_attachment_for_errors, which would be passed a report and an attachment to search.
I also modified some of the grub_errors based off a discussion with cjwatson.
--
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/further-grub-handling/+merge/68457
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7552 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20110719/6e9966be/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list