[Merge] lp:~csurbhi/partman-btrfs/testing-subvol into lp:~ubuntu-core-dev/partman-btrfs/ubuntu

[Surbhi Palande]

Surbhi Palande has proposed merging lp:~csurbhi/partman-btrfs/testing-subvol into lp:~ubuntu-core-dev/partman-btrfs/ubuntu.

Requested reviews:
  Ubuntu Installer Team (ubuntu-installer)

For more details, see:
https://code.launchpad.net/~csurbhi/partman-btrfs/testing-subvol/+merge/47975

Our aim is to be able to do automatic snapshots of home and / separately. Having a separate subvolume for / and another subvolume for /home allows us to take snapshots of these subvolumes independently. 

Note that we have two basic scenarios:
1) /home is a separate partition and is mounted on dir home in /
2) /home is not a separate partition and is simply a dir under /

We need to basically achieve the following through the installer:
1) create the subvolume @ for / and @home for /home (just a naming convention discussed)
2) mount @ on /  and mount @home on /home
3) prepare fstab such that every time the subvolumes are mounted.

====

Code:
1) fstab.d/btrfs checks if /home is a separate partition or not. If / is btrfs formatted then it adds an entry to mount the subvol=@home on /home even if /home is not a separate partition.
2) In case /home is a separate btrfs partition then it adds an entry to mount the subvolume=@home on /home.
3) Only when both / and /home are not btrfs formatted, then no entry corresponding to @home is added.

mount.d/btrfs gets the mountpoints by reading the fstab.d/btrfs and so it always gets to mount /home in both the cases discussed above.

======

Testing:
1) have tested the code for the following cases:
a) /home:btrfs /:btrfs
b) no separate /home, /:btrfs
c) /home:ext2 /:btrfs
d) /home:btrfs, /:ext2
e) /home:ext2 /:ext2
f) no separate /home, /:ext2

====

Please do let me know what you think of it! Thanks!














-- 
https://code.launchpad.net/~csurbhi/partman-btrfs/testing-subvol/+merge/47975
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/partman-btrfs/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2897 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20110131/4a2a3864/attachment.diff>