[Merge] lp:~brian-murray/ubuntu/oneiric/apport/no-package-hardware-errors into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu

Martin Pitt martin.pitt at ubuntu.com
Tue Aug 30 09:30:30 UTC 2011


Review: Needs Fixing
Thanks for this!

 * Can this please guard against report['Df.txt'] not existing?

 * The first part can be simplified by checking for /, /usr/, var in one "if" condition, and just appending to devs_to_check. root_device et al are not used anywhere else, and var_device is currently determined in vain (not used at all).

-- 
https://code.launchpad.net/~brian-murray/ubuntu/oneiric/apport/no-package-hardware-errors/+merge/73287
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~brian-murray/ubuntu/oneiric/apport/no-package-hardware-errors into lp:~ubuntu-core-dev/ubuntu/oneiric/apport/ubuntu.



More information about the Ubuntu-reviews mailing list