[Merge] lp:~r.phate/computer-janitor/bug-458872 into lp:computer-janitor

[Rigved Rakshit]

Rigved Rakshit has proposed merging lp:~r.phate/computer-janitor/bug-458872 into lp:computer-janitor.

Requested reviews:
  computer-janitor-hackers (computer-janitor-hackers)
Related bugs:
  Bug #458872 in computer-janitor (Ubuntu): "Don't mark for removal manually installed packages"
  https://bugs.launchpad.net/ubuntu/+source/computer-janitor/+bug/458872

For more details, see:
https://code.launchpad.net/~r.phate/computer-janitor/bug-458872/+merge/56079

Description:
Compared the list of installed packages registered with dpkg (using a shell script because could not find python-dkpg bindings)  and apt (using apt_pkg module).
The packages registered with dpkg, but not with apt, have definitely been manually installed.
So, those packages which have been manually installed are white-listed.

Fixes bug 458872

How to test:

1. Install a package manually via dpkg, like the getdeb-repository package available here: http://archive.getdeb.net/install_deb/getdeb-repository_0.1-1~getdeb1_all.deb

2. Ideally, a refresh of the apt cache or possibly a system restart is required, before the package will even register with apt-get autoremove.
Check the same with CJ.

3. apt-get autoremove should suggest that you remove getdeb-repository but CJ should not give this suggestion.
-- 
https://code.launchpad.net/~r.phate/computer-janitor/bug-458872/+merge/56079
Your team computer-janitor-hackers is requested to review the proposed merge of lp:~r.phate/computer-janitor/bug-458872 into lp:computer-janitor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 390152 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20110403/16dcf2df/attachment-0001.diff>