[Merge] lp:~gunnarhj/language-selector/fix-553162 into lp:language-selector

[Martin Pitt]

Review: Needs Fixing
Hello Gunnar,

many thanks for working on this! Some comments:

- in the beginning of writeUserLanguageSetting() you moved the first line of code above the function's docstring, please revert.

- Thanks for moving the _update_gdm_dmrc() from the "system.." to the "user.." configuration writing, nice catch.

- the stuff that data/gdm-lang-unset.sh and data/language-environment.sh are doing, can we please intregrate this into language-selector itself instead of inflicting it on every login? I don't think we need to try too hard to fix the variables on upgrades. There's too much that can go wrong, and it'll lead to unintended changes for some people. I think we should update the system and ~/.dmrc and ~/.profile variables in language-selector only, when you run it and change your configuration.

Thank you!
-- 
https://code.launchpad.net/~gunnarhj/language-selector/fix-553162/+merge/39791
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~gunnarhj/language-selector/fix-553162 into lp:language-selector.