Queue rejections now require a reason/comment

Adam Conrad adconrad at ubuntu.com
Thu May 30 08:10:19 UTC 2013


Some may have already noticed, and others will soon notice that queue
rejections now require a comment.  This is enforced not at the API
level but at the tool/UI level.  Please update your local branches of
ubuntu-archive-tools to get the new shiny.

There are three (currently) UIs that take advantage of this: the web
UI on launchpad.net/distro/series/+queue, the command-line queue tool,
and bdmurray's new in-progress sru-review tool.

These rejection comments are NOT meant to be a substitute for in-depth
review and feedback, if such is required.  If so, please still follow
up with the uploader via a bug comment, email, or IRC.  Fair examples
of reject messages would be something like:

 - "lacked proper patch headers in foo.patch; changelog missed bug ref"
 - "https://bugs.launchpad.net/ubuntu/+source/file/+bug/248619/comments/2"
 - "superseded by newer version in the security pocket, please merge"
 - "removed from queue per uploader request"
 - "changelog was excessively German, please apply English grammar"
 - "out of spite"

The point is to be brief but informative.  For now, this isn't being
logged anywhere (but that will be a future goal), it's just in the
rejection email sent to the uploader.  Keep that in mind, as they are
your target audience.  If you can tell them everything you need to in
a quick message, cool.  If you need a longer followup elsewhere, do
so and refer back to it.

When this ends up becoming an audit trail thing as well, we might look
at messages with sane text formatting, or some other form of clever,
so one can spew a full review in there, but for now, the goal is just
to tell the uploader *something* in the email other than "your upload
was rejected, and you now get to play IRC tag to figure out why".

... Adam

PS: If you intend to use the last two reject comment examples, do be
    aware that reject emails also list the archive admin who did the
    reject, you're not anonymous.  Just sayin'.



More information about the Ubuntu-release mailing list