Network Debug Tool-kit

[Javier Domingo Cansino]

I would propose you uploaded this to some source code hosting platform,
to ease access to it and track issues you might have (i.e. Github).

On the code you have done:

General comments
----------------
- I would recommend you didn't create logs by default, and you let them
be created by the user. If you want to generate a log, just execute it
as ./mmcli-test.sh > log.txt for example, so that you have the same
result (or if you are more exquisite, ./mmcli-test.sh | tee log.txt).
  Also, I wouldn't neither create a folder called logs for storing logs.
Letting the user choose is the correct way IMO.

- In general, I would propose less fancy output and more focus in the
functionality. That way, you improve maintainability.

mmcli-test.sh
-------------

- 'echo "" 2>&1', does not need the '2>&1' part, as echo does always
output to stdout.

- I would delete '| tee -a "$log"' part to improve readability, either
by letting the user create the function or rewriting it as a function
for logging

modem-manager-debug.sh and network-manager-debug.sh
---------------------------------------------------
- If you want to stop a service, recommended way is to first do it using
the service command, 'sudo service network-manager stop', and then go
the assassin way with killall

Hope this feedback is valuable!

Javier Domingo Cansino


On 08/13/2014 02:38 PM, Alberto Salvia Novella wrote:
> I have written a tool-kit that could make network debugging more
> straightforward for non technical users:
> 
> <https://bugzilla.gnome.org/attachment.cgi?id=283124>
> 
> 
> I wanted to know if you see in this tool-kit as a perfect substitute of
> the documentation, or if there is something missing:
> 
>  - <https://wiki.ubuntu.com/DebuggingModemmanager>
>  -
> <http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/debugging-3g/modem-debugging-with-mmcli>
> 
> 
> 
> Thank you.
> 
> 
>