[Bug 730633] Re: lashd 6 doesn't load projects from JFS (patch included)
Daniel T Chen
seven.steps at gmail.com
Wed Jul 20 18:20:33 UTC 2011
** Description changed:
Binary package hint: lashd
- lashd-0.6.0~rc2-1ubuntu2 (Maverick and Natty) doesn't restore projects
- from JFS filesystems upon startup.
+ SRU Impact statement:
+ lashd-0.6.0~rc2-1ubuntu2 (Maverick and Natty) doesn't restore projects from JFS filesystems upon startup.
This is because the code uses an unreliable, non-portable check for
dirent.d_type == DT_DIR, which fails on many filesystems, causing lashd
to think that the project directories are not, in fact, directories.
- The attached 05_stat.patch uses stat / S_ISDIR to properly check
- dentries (and fixes a similar problem with the lashd "appdb"). It has
- been tested in my PPA.
+ Patch / resolution:
+ The attached 05_stat.patch uses stat / S_ISDIR to properly check dentries (and fixes a similar problem with the lashd "appdb"). It has been tested in my PPA.
+
+ TEST CASE:
+ Install lashd on 11.04 and attempt to load a project hosted on JFS. It will fail.
+
+ Regression risk:
+ Slim to none.
** Patch added: "Patch for natty-proposed"
https://bugs.launchpad.net/ubuntu/natty/+source/lash/+bug/730633/+attachment/2221562/+files/lash_0.6.0%7Erc2-5ubuntu0.1.debdiff
** Description changed:
Binary package hint: lashd
SRU Impact statement:
lashd-0.6.0~rc2-1ubuntu2 (Maverick and Natty) doesn't restore projects from JFS filesystems upon startup.
This is because the code uses an unreliable, non-portable check for
dirent.d_type == DT_DIR, which fails on many filesystems, causing lashd
to think that the project directories are not, in fact, directories.
Patch / resolution:
The attached 05_stat.patch uses stat / S_ISDIR to properly check dentries (and fixes a similar problem with the lashd "appdb"). It has been tested in my PPA.
+ Oneiric is not affected, as the lash source package is not available.
+
+ Patch for natty-proposed:
+ https://bugs.launchpad.net/ubuntu/natty/+source/lash/+bug/730633/+attachment/2221562/+files/lash_0.6.0~rc2-5ubuntu0.1.debdiff
TEST CASE:
Install lashd on 11.04 and attempt to load a project hosted on JFS. It will fail.
Regression risk:
Slim to none.
** Changed in: lash (Ubuntu Natty)
Assignee: (unassigned) => Daniel T Chen (crimsun)
** Tags removed: patch
** Tags added: patch-accepted-debian
--
You received this bug notification because you are a member of Ubuntu
Review Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/730633
Title:
lashd 6 doesn't load projects from JFS (patch included)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lash/+bug/730633/+subscriptions
More information about the Ubuntu-patch-reviews
mailing list