[Bug 1994521] Fix merged to cinder (stable/2023.1)

[OpenStack Infra]

Reviewed:  https://review.opendev.org/c/openstack/cinder/+/882782
Committed: https://opendev.org/openstack/cinder/commit/af040f92537928401ccb167943d1edb6da80ad4e
Submitter: "Zuul (22348)"
Branch:    stable/2023.1

commit af040f92537928401ccb167943d1edb6da80ad4e
Author: Rajat Dhasmana <rajatdhasmana at gmail.com>
Date:   Wed Oct 26 09:55:43 2022 +0000

    3PAR: Error out if vol cannot be converted to base
    
    Consider volume and snapshots as below:
    
    v1
    |
    `-- s1
        |
        `-- v2
            |
            `-- s2
    
    User initiated deletion of snapshot s1.
    It failed with some vague message.
    
    Initially, it was suspected that ...
    While copying volume v2 (sometimes an intermediate step to break
    volume dependency), we send a request to clone the volume v2 to new
    base volume; and the exception [1] isn't handled properly.
    
    [1] Conflict (HTTP 409) 32 - volume has a child
    
    However, on further investigation it was found that ...
    after a new volume v2 (omv-<id>) is created and
    when we try to delete old volume v2 (osv-<id>),
    at this point the exception [1] is thrown as error.
    
    This is now handled gracefully. Appropriate error is thrown
    if the volume (v2) has snapshot (s2).
    
    Co-Authored-By: raghavendrat <raghavendra-uddhav.tilay at hpe.com>
    Closes-Bug: #1994521
    Change-Id: I5e7fb425c92cdf8c16d5a86a58ca1a52421543d7
    (cherry picked from commit dfd8f99743a29220ca3face5fdf00a1a6071cf48)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to cinder in Ubuntu.
https://bugs.launchpad.net/bugs/1994521

Title:
  HPE3PAR: Failing to clone a volume having children

Status in Cinder:
  Fix Released
Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive antelope series:
  Triaged
Status in Ubuntu Cloud Archive bobcat series:
  Fix Released
Status in Ubuntu Cloud Archive yoga series:
  In Progress
Status in cinder package in Ubuntu:
  Fix Released
Status in cinder source package in Focal:
  In Progress
Status in cinder source package in Jammy:
  Fix Committed
Status in cinder source package in Mantic:
  Fix Released
Status in cinder source package in Noble:
  Fix Released

Bug description:
  [Impact]

  The customer faced issue when they are using nova with 3par storage.
  they can't delete volume if there is children and it is attached to vm.

  it makes sense they can't delete it as the children has attachment but
  nova should expose proper error when trying deletion.

  [Test Case]

  The customer has the required hardware for testing this.

  Volume->Snapshot->Volume2
  Volume2 is attached to some VM.
  and can't delete Volume without proper error msg.

  [Where problems could occur]
  This is related to hpe3par storage.
  snapshot handling could be issue with this patch.
  deleting volume could be issue with this patch.

  [Others]

  Original Desc

  When we try to delete a snapshot, we flatten it's dependent volumes by copying them to a new volume and deleting the original one.
  We fail to copy the volume when it has children and it is not handled in the code.

  : hpe3parclient.exceptions.HTTPConflict: Conflict (HTTP 409) 32 -
  volume has a child

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1994521/+subscriptions