[Bug 2065856] Re: SEGFAULTs in v4.3 with GlusterFS

[Christian Ehrhardt ]

Being an upstream merged change makes it ok for Oracular,
but for the backports it is complex as it is messing with memory management and as you said does not apply as-is.

Some comments and adaptations I'll have to make:
- thanks for having dep-3 patch headers at all, that is often forgotten
- usually if modified from the original it states backport instead of upstream, but I can fix that along the way
- the version in the changelog would not work. Noble and Oracular are both at 4.3-8ubuntu1. Only Oracular can go to the proposed 4.3-8ubuntu2 noble will need to go to 4.3-8ubuntu1.1. If you are curious about this you can read [1] which is an explanation on this more complex than it should be topic :-)
- it is no rule but personal preference to list the related patch in a changelog

Other than that this LGTM, it is complex to test and I need to ask you
if you are willing and able to do the same for all releases that need
SRU verification (noble + mantic in this case).

OTOH strictly speaking the rule is to fix all "later" releases.
We could as well assume that nfs-ganesha is probably not the most common mantic workload and it goes out of support soon. So instead of messing with yet another version we could stick to what you tested already as oracular and noble have the same.

I'll try to prep MPs with the same content you had but my fixes I mentioned above on top.
You can give me a +1 that this matches what you have and expected and then I could upload it.

[1]: https://github.com/canonical/ubuntu-maintainers-
handbook/blob/main/VersionStrings.md

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to nfs-ganesha in Ubuntu.
https://bugs.launchpad.net/bugs/2065856

Title:
  SEGFAULTs in v4.3 with GlusterFS

Status in nfs-ganesha package in Ubuntu:
  In Progress
Status in nfs-ganesha source package in Mantic:
  New
Status in nfs-ganesha source package in Noble:
  New
Status in nfs-ganesha source package in Oracular:
  In Progress

Bug description:
  [ Impact ]

   * Users experience SEGFAULTs when Ganesha fails to communicate with
  Gluster, causing the NFS share to disappear.

   * The patch refactors how free_space() is called to avoid the null
  pointer deference.

  [ Test Plan ]

   * I experienced crashes about once per day on volumes with heavy
  large file random access. I've been running the proposed patch since
  2024-05-16 and haven't experienced a single crash.

   * The test plan is to run the packages from proposed for at least 5
  days, under the same load as when the bug happened, and confirm that
  the crashes reported in this bug no longer happen.

  [ Other Info ]

   * Commit which added this patch: https://github.com/nfs-ganesha/nfs-ganesha/commit/336abcba0b9e0dae0aadb4657c311d04862f2028
   * Issue discussion: https://github.com/nfs-ganesha/nfs-ganesha/issues/904

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nfs-ganesha/+bug/2065856/+subscriptions