[Bug 2073242] Re: Tests require python-oauth2client

[Nick Rosbrook]

** Changed in: cinder (Ubuntu)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to cinder in Ubuntu.
https://bugs.launchpad.net/bugs/2073242

Title:
  Tests require python-oauth2client

Status in Cinder:
  Confirmed
Status in cinder package in Ubuntu:
  Fix Committed

Bug description:
  Cinder has implemented support for both oauth2client and google-auth.
  However, tests still require oauth2client.

  The affected file is cinder/tests/unit/backup/fake_google_client.py .
  It does the following:

      from oauth2client import client
      [...]
                  raise client.Error

  I've tried alternatives but a) I'm not familiar enough with the
  codebases to be entirely confident about them, b) the codepath has not
  been taken during my tests and I therefore had no way of verifying my
  changes.

  Considering the codepath appears to not be taken during normal
  operation, a generic Exception seems acceptable to me, at least in the
  short term. I plan on preparing such a chance soon in order to fix
  current cinder builds.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/2073242/+subscriptions