[Bug 1939723] Re: neutron-ovn-db-sync generates insufficient flow

[Mauricio Faria de Oliveira]

Hey Nikhil,

Thanks for performing the verifications in such a detailed manner.

I happened to be looking at this SRU/bug and had some observations:

> the patch verification testing details are in
https://pastebin.canonical.com/p/2J6C9tx4np/

Please always keep the verification steps/logging (if needed) in the bug
(as comments or attachments, as appropriate), for documentation purposes.

Even though pastebins are useful, they might be removed, and in this case,
canonical's pastebin isn't available externally (ubuntu's pastebin is),
which restricts the availability to other people/community members.

> I have tested this fix on focal/ussuri [...]
> Since the patch is exactly the same for the cloud archive, I am marking that done as well.

Although this is ultimately up to the Cloud Archive's release team, I
would like to suggest the Cloud Archive to be separately verified too.

The reason is, there is more involved in the verification than just the source code change alone.
Specially in the case of the Cloud Archive, there are different (more recent) package versions that may be pulled and are exercised as part of the verification steps (e.g., python dependencies or other libraries).
Thus in practice, the actually verified code is different, even if the patch is the same.

Thanks!
Mauricio

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1939723

Title:
  neutron-ovn-db-sync generates insufficient flow

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive ussuri series:
  Fix Committed
Status in Ubuntu Cloud Archive victoria series:
  Fix Released
Status in Ubuntu Cloud Archive wallaby series:
  Fix Released
Status in Ubuntu Cloud Archive xena series:
  Fix Released
Status in Ubuntu Cloud Archive yoga series:
  Fix Released
Status in Ubuntu Cloud Archive zed series:
  Fix Released
Status in neutron:
  Fix Released
Status in neutron package in Ubuntu:
  Fix Released
Status in neutron source package in Focal:
  Fix Committed

Bug description:
  = Original bug description =

  In OpenStack version Victoria, neutron-ovn-db-sync generates insufficient flow for port no security-group or disable port-security.
  ---> As a result, the port is not connected to the network.

  = Ubuntu SRU details =

  [Impact]
  The neutron-ovn-db-sync tool is used to syncing neutron networks and ports with OVN databases. When the tool is run, ports with port security disabled are incorrectly being added to the drop port group causing all traffic to be dropped by default.

  [Test Case]
  - Create a VM
  - Disable port security
  - Remove NB & SB DB
  - Run command neutron-ovn-db-sync-util to resync from neutron to NB database
  neutron-ovn-db-sync-util --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini --ovn-neutron_sync_mode repair
  - Restart ovn-controller
  - VM with port disable security die without the fix

  [Regression Potential]
  This is a simple patch that fixes the logic of an if statement. This has been fixed in the victoria+ Ubuntu package versions since 2022-01-12, and has been fixed in the upstream stable/ussuri branch since 2021-11-11.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1939723/+subscriptions