[Bug 1965297] Re: l3ha don't set backup qg ports down

[OpenStack Infra]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/845406
Committed: https://opendev.org/openstack/neutron/commit/61e951d668c7a6da97a71b8a7d8885fe446c685e
Submitter: "Zuul (22348)"
Branch:    stable/wallaby

commit 61e951d668c7a6da97a71b8a7d8885fe446c685e
Author: Edward Hope-Morley <edward.hope-morley at canonical.com>
Date:   Thu Mar 17 12:56:21 2022 +0000

    Partially revert "Do not link up HA router gateway in backup node"
    
    This partially reverts commit c52029c39aa824a67095fbbf9e59eff769d92587.
    
    We revert everything except one minor addition to
    neutron/agent/l3/ha_router.py which ensures that ha_confs path is
    created when the keepalived manager is initialised.
    
    Closes-Bug: #1965297
    Change-Id: I14ad015c4344b32f7210c924902dac4e6ad1ae88
    (cherry picked from commit 36bf1df46df4de8f9ed0c19e1118480ce2e55d8a)
    (cherry picked from commit 7cf7ae05659b363e54fbb04d2c02f91b17763921)
    (cherry picked from commit 22f231fd8b2e145e63753712406ddbad01d0d08a)


** Tags added: in-stable-wallaby

** Tags added: in-stable-victoria

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1965297

Title:
  l3ha don't set backup qg ports down

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive ussuri series:
  Fix Released
Status in Ubuntu Cloud Archive victoria series:
  Fix Released
Status in Ubuntu Cloud Archive wallaby series:
  Fix Released
Status in Ubuntu Cloud Archive xena series:
  Fix Released
Status in Ubuntu Cloud Archive yoga series:
  Fix Released
Status in Ubuntu Cloud Archive zed series:
  Fix Released
Status in neutron:
  Fix Released
Status in neutron package in Ubuntu:
  Fix Released
Status in neutron source package in Focal:
  Fix Released
Status in neutron source package in Impish:
  Won't Fix
Status in neutron source package in Jammy:
  Fix Released
Status in neutron source package in Kinetic:
  Fix Released

Bug description:
  The history to this request is as follows; bug 1916024 fixed an issue
  that subsequently had to be reverted due to a regression that it
  introduced (see bug 1927868) and the original issue can once again
  present itself in that keepalived is unable to send GARP on the qg
  port until the port is marked as UP by neutron which in loaded
  environments can sometimes take longer than keepalived will wait (e.g.
  when an l3-agent is restarted on a host that has hundreds of routers).
  The reason why qg- ports are marked as DOWN is because of the patch
  landed as part of bug 1859832 and as I understand it there is now
  consensus from upstream [1] to revert that patch as well and a better
  solution is needed to fix that particular issue. I have not found a
  bug open yet for the revert hence why I am opening this one.

  [1]
  https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-03-04-14.03.log.txt

  ------------

  [Impact]
  Please see LP bug description for full details but in short, this patch is a revert of a patch that has show instability in the field for users of Neutron L3HA.

  [Test Plan]
    * Deploy Openstack with Neutron L3 HA enabled
    * Create a number of HA routers
    * Check all qrouter namespaces and ensure that the qg- port is UP in all

  [Regression Potential]
  Since the original patch was intended to address issues with MLDv2 it is possible that reverting it will re-introduce those issues and a new patch will need to be proposed to address that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1965297/+subscriptions