[Bug 1993005] Fix proposed to horizon (stable/2023.1)

[OpenStack Infra]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/horizon/+/878436

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to horizon in Ubuntu.
https://bugs.launchpad.net/bugs/1993005

Title:
  Swift file upload fails on zed with "This name already exists." for
  non-existing files

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Triaged

Bug description:
  Swift file upload fails on zed with "This name already exists." for
  non-existing files.

  Please see attached screenshot for the behavior.

  I've narrowed this down to a change in 'function getObjectDetails' in
  swift.service.js.

  The 'Migrate to AngularJS v1.8.2' change in commit f044c4b0a3 updated
  the file with:

  @@ -297,9 +297,9 @@
         );
         if (ignoreError) {
           // provide a noop error handler so the error is ignored
  -        return promise.error(angular.noop);
  +        return promise.catch(angular.noop);
         }
  -      return promise.error(function () {
  +      return promise.catch(function onError() {
           toastService.add('error', gettext('Unable to get details of the object.'));
         });
       }

  If I revert these 2 lines of code, I'm able to upload a file again
  without the error, however I'm also able to upload it twice and
  overwrite the existing file the 2nd time.

  Update: Specifically reverting the first LOC to the following seems to
  fix this:

  return promise.error(angular.noop);

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1993005/+subscriptions