[Bug 2019175] Re: [SRU] Fix None comparison when sorting by `updated_at`

[Ponnuvel Palaniyappan]

Just to clarify, the previous two verification I did where using:

1:14.2.0-0ubuntu2~cloud0 (on Bionic, ussuri-proposed)
1:15.1.0-0ubuntu1~cloud1 (on Focal, victoria-proposed)

Corey confirmed (also clarified by Ed) a separate SRU verification for Focal will be needed.
So I'll do another verification using 1:14.2.0-0ubuntu2 on Focal. Thanks for all clearing it up!

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to heat in Ubuntu.
https://bugs.launchpad.net/bugs/2019175

Title:
  [SRU] Fix None comparison when sorting by `updated_at`

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive ussuri series:
  Fix Committed
Status in Ubuntu Cloud Archive victoria series:
  Fix Released
Status in Ubuntu Cloud Archive wallaby series:
  Fix Released
Status in Ubuntu Cloud Archive xena series:
  Fix Released
Status in Ubuntu Cloud Archive yoga series:
  Fix Released
Status in Ubuntu Cloud Archive zed series:
  Fix Released
Status in heat package in Ubuntu:
  Fix Released
Status in heat source package in Focal:
  Incomplete
Status in heat source package in Jammy:
  Fix Released

Bug description:
  StoryBoard link: https://storyboard.openstack.org/#!/story/2009653

  [Impact]

  If resource candidates were never updated before then their `updated_at` value in the db remain `None`.
  This prevents future resource updates when any of of the resources in db has been replaced without being updated before.

  [Test Plan]

  A. Reproducer steps:
    1. create a project and nova instances using > 1 vcpus in that project
    2. create a stack with a OS::Nova::Quota resource managing the project's quotas
    3. change the vcpu quota to an invalid value (i.e. 0) and update the stack three times
    4. set a valid quota and update the stack again

  Then stack update will fail with the message:
  "'<' not supported between instances of 'datetime.datetime' and 'NoneType'"
  (openstack stack show <stackname>)

  B. Install the heat package with fix, restart heat service
  C. Re-run step 4 from reproducer steps again (update the stack once again)
  D. Confirm that resource update succeeds and the stack update shows 'UPDATE_COMPLETE' with no errors (can repeat several times as well) or fails with a different message for another reason

  [Where problems could occur]

  If the `created_at` value happens to `None` as well for some reason then this will end up failing in the same manner.
  Newer OpenStack versions already contain this fix and released packages (Wallaby, Yoga, and Zed) work as expected.

  [Other info]

  The fix was backported to Ussuri after the last release of Heat (14.2).
  Upstream PR: https://review.opendev.org/c/openstack/heat/+/837697

  This was impacting a user who is using Ussuri. Latest releases already contain the fix in the following packages:
  Wallaby: heat_16.1.0-0ubuntu1~cloud0
  Yoga: heat_18.0.0-0ubuntu1.2~cloud0
  Zed: heat_19.0.0-0ubuntu1.2~cloud0

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2019175/+subscriptions