[Bug 1947063] Re: Missing dependency to sysfsutils, nvme-cli

[OpenStack Infra]

Reviewed:  https://review.opendev.org/c/openstack/charm-cinder-purestorage/+/902643
Committed: https://opendev.org/openstack/charm-cinder-purestorage/commit/cf31f0dc2d3574fa0f311685bb0a9ad7fe54ebad
Submitter: "Zuul (22348)"
Branch:    stable/yoga

commit cf31f0dc2d3574fa0f311685bb0a9ad7fe54ebad
Author: Nobuto Murata <nobuto.murata at canonical.com>
Date:   Tue Dec 5 21:13:30 2023 +0900

    Make sure sysfsutils (for systool) is available up to Yoga
    
    The systool command is necessary for the FC scenario, but Ubuntu
    packages do not pull it as a dependency. It has to be installed by each
    storage backend charm when:
    
    - cinder-volume service is not co-located with nova-compute
    - nova-compute charm doesn't have the `use-multipath` option enabled
      even when it's co-located
    
    However, systool is only necessary up to Yoga so no need to merge this
    for zed onwards:
    https://opendev.org/openstack/os-brick/src/branch/master/releasenotes/notes/no-systool-use-b7bc430de1033670.yaml
    
    Closes-Bug: #1947063
    Change-Id: I366bf71161e275638403a5a815c98341da7d4f6f


** Changed in: charm-cinder-purestorage/yoga
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to python-os-brick in Ubuntu.
https://bugs.launchpad.net/bugs/1947063

Title:
  Missing dependency to sysfsutils, nvme-cli

Status in OpenStack Cinder Pure Storage Charm:
  Invalid
Status in OpenStack Cinder Pure Storage Charm yoga series:
  Fix Committed
Status in Ubuntu Cloud Archive:
  Fix Released
Status in python-os-brick package in Ubuntu:
  Fix Released

Bug description:
  At the moment, python3-os-brick pulls iSCSI dependency such as open-
  iscsi but doesn't pull FC dependency as sysfsutils at all.

  os-brick is actively using the "systool" command to detect HBA and bais if it's not installed. It would be nice to add sysfsutils package at least as Recommends of python3-os-brick.
  https://github.com/openstack/os-brick/blob/4baa502ec8c6c62184c474f126c0ad07eb3409f1/os_brick/initiator/linuxfc.py#L151-L177

  
  $ apt depends python3-os-brick 
  python3-os-brick
    Depends: open-iscsi
    Depends: os-brick-common (= 5.0.1-0ubuntu1)
    Depends: python3-babel (>= 2.3.4)
    Depends: python3-eventlet (>= 0.30.1)
    Depends: python3-os-win (>= 5.4.0)
    Depends: python3-oslo.concurrency (>= 4.4.0)
    Depends: python3-oslo.context (>= 1:3.1.1)
    Depends: python3-oslo.i18n (>= 5.0.1)
    Depends: python3-oslo.log (>= 4.4.0)
    Depends: python3-oslo.privsep (>= 2.4.0)
    Depends: python3-oslo.serialization (>= 4.1.0)
    Depends: python3-oslo.service (>= 2.5.0)
    Depends: python3-oslo.utils (>= 4.8.0)
    Depends: python3-pbr (>= 5.5.1)
    Depends: python3-requests (>= 2.25.1)
    Depends: python3-retrying (>= 1.2.3)
    Depends: python3-tenacity (>= 6.3.1)
    Depends: <python3:any>
      python3:i386
      python3
    Suggests: python-os-brick-doc

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-cinder-purestorage/+bug/1947063/+subscriptions