[Bug 1959712] Re: [SRU] Add iSCSI support to HPE 3PAR driver for Primera 4.2 and higher

[Nobuto Murata]

Tested and verified with cloud-archive:victoria-proposed.

apt-cache policy cinder-common
cinder-common:
  Installed: 2:17.2.0-0ubuntu1~cloud1
  Candidate: 2:17.2.0-0ubuntu1~cloud1
  Version table:
 *** 2:17.2.0-0ubuntu1~cloud1 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu focal-proposed/victoria/main amd64 Packages
        100 /var/lib/dpkg/status
     2:17.2.0-0ubuntu1~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu focal-updates/victoria/main amd64 Packages
     2:16.4.1-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     2:16.1.0-0ubuntu1 500
        500 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages
     2:16.0.0~b3~git2020041012.eb915e2db-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages

[before applying -proposed]

2022-02-24 13:56:09.072 52866 ERROR cinder.volume.drivers.hpe.hpe_3par_iscsi [req-d69ea8d0-9059-46de-b931-d5acf2d6f9c1 - - - - -] For Primera, only FC is supported. iSCSI cannot be used
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager [req-d69ea8d0-9059-46de-b931-d5acf2d6f9c1 - - - - -] Failed to initialize driver.: NotImplementedError
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager Traceback (most recent call last):
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager   File "/usr/lib/python3/dist-packages/cinder/volume/manager.py", line 466, in _init_host
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager     self.driver.do_setup(ctxt)
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager   File "/usr/lib/python3/dist-packages/cinder/volume/drivers/hpe/hpe_3par_base.py", line 438, in do_setup
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager     self._do_setup(common)
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager   File "/usr/lib/python3/dist-packages/cinder/volume/drivers/hpe/hpe_3par_iscsi.py", line 149, in _do_setup
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager     raise NotImplementedError()
2022-02-24 13:56:09.073 52866 ERROR cinder.volume.manager NotImplementedError


[after applying -proposed]
2022-02-24 14:18:26.737 58796 INFO cinder.volume.flows.manager.create_volume [req-a12f1979-f76f-4187-9e23-cc667d0ef403 2271c96c9b804f4e86e12ab55a6d9344 268e52aa19b040fca0430b9616a0017e - - -] Volume volume-028e4021-506c-43eb-9f49-d705a420d216 (028e4021-506c-43eb-9f49-d705a420d216): created successfully


$ openstack volume list                                                                                                                         
+--------------------------------------+-------+-----------+------+-------------+
| ID                                   | Name  | Status    | Size | Attached to |
+--------------------------------------+-------+-----------+------+-------------+
| 028e4021-506c-43eb-9f49-d705a420d216 | test2 | available |   10 |             |
| 57c761cf-5a7e-401d-8b91-10872b5f7804 | test1 | error     |   10 |             |
+--------------------------------------+-------+-----------+------+-------------+

test1 (w/error) is before, and test2 (w/ available) is after applying
-proposed.

** Tags removed: verification-victoria-needed
** Tags added: verification-victoria-done

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to cinder in Ubuntu.
https://bugs.launchpad.net/bugs/1959712

Title:
  [SRU] Add iSCSI support to HPE 3PAR driver for Primera 4.2 and higher

Status in Ubuntu Cloud Archive:
  Invalid
Status in Ubuntu Cloud Archive ussuri series:
  Fix Committed
Status in Ubuntu Cloud Archive victoria series:
  Fix Committed
Status in cinder package in Ubuntu:
  Invalid
Status in cinder source package in Focal:
  Fix Committed

Bug description:
  [Description]
  OpenStack cinder in Focal (OpenStack Ussuri) is lacking iSCSI support for HPE Primera 4.2 and higher. This is now supported in Cinder and we would like to enable it in Ubuntu Focal as well as OpenStack Ussuri.

  The rationale for this SRU falls under harware enablement for Long
  Term Support releases.

  [Test Case]
  1. Deploy OpenStack with:
   - HPE 3PAR *iSCSI* driver enabled for Cinder
   - with Primera >= 4.2
    as per: https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/hpe-3par-driver.html
  2. Create a volume
    openstack volume create (--type hpe-primera) --size 10 sru-test-before

  3. Confirm the volume is successfully created while it gave an error
  as "For Primera, only FC is supported. iSCSI cannot be used"
  previously.

  [Regression Potential]
  This is a pretty simple patch. Where the code used to always raise a not implemented error for Primera, it now raises the not implemented error only for < Primera 4.2. Where things could go wrong? It's possible the version checking could have an issue but that code seems standard and the upstream patch has been merged back to stable/victoria [1]. Regression testing will cover that code path as well.
  [1] https://review.opendev.org/c/openstack/cinder/+/820611

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1959712/+subscriptions