[Bug 1965819] Related fix merged to neutron (stable/xena)

[OpenStack Infra]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/838783
Committed: https://opendev.org/openstack/neutron/commit/af6b54a24b444d6014a4b6c7436046ccfb3aa74f
Submitter: "Zuul (22348)"
Branch:    stable/xena

commit af6b54a24b444d6014a4b6c7436046ccfb3aa74f
Author: Terry Wilson <twilson at redhat.com>
Date:   Tue Mar 22 04:12:08 2022 +0000

    Fix setting table monitoring conditions
    
    After the monitor_cond_since/update3 support patch in ovs
    (46d44cf3be0), directly setting table.condition is broken. This
    isn't something that was every truly supported. Prior to that
    patch, using Idl.cond_change() before a connection was made
    did not work, but after that patch it does.
    
    This patch uses the old behavior when the OVS library does not
    have the ConditionState object, and uses cond_change() otherwise.
    
    Related-Bug: #1965819
    Change-Id: I0503037b803a3c99fb7988bc20394c111ac456db
    (cherry picked from commit a13a4cb2da03e2cdce04b0e7b4bc30e44ebdbd02)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to python-ovsdbapp in Ubuntu.
https://bugs.launchpad.net/bugs/1965819

Title:
  list object has no attribute 'acked'

Status in networking-ovn:
  New
Status in neutron:
  In Progress
Status in ovsdbapp:
  Fix Released
Status in neutron package in Ubuntu:
  Fix Released
Status in python-ovsdbapp package in Ubuntu:
  Fix Released

Bug description:
  Using python-ovs master, there are errors such as:

  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn [None req-81ffbcd9-59d1-498a-aea2-d57e0d515ff2 None None] OVS database connection to OVN_Southbound failed with error: ''list' object has no attribute 'acked''. Verify that the OVS and OVN services are available and that the 'ovn_nb_connection' and 'ovn_sb_connection' configuration options are correct.: AttributeError: 'list' object has no attribute 'acked'
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn Traceback (most recent call last):
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn   File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py", line 127, in start_connection
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn     self.ovsdb_connection.start()
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn   File "/usr/local/lib/python3.10/site-packages/ovsdbapp/backend/ovs_idl/connection.py", line 83, in start
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn     idlutils.wait_for_change(self.idl, self.timeout)
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn   File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py", line 53, in wait_for_change
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn     while idl_.change_seqno == seqno and not idl_.run():
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn   File "/opt/stack/ovs/python/ovs/db/idl.py", line 506, in run
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn     self.__send_monitor_request()
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn   File "/opt/stack/ovs/python/ovs/db/idl.py", line 814, in __send_monitor_request
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn     not ConditionState.is_true(table.condition.acked)):
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn AttributeError: 'list' object has no attribute 'acked'
  ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.impl_idl_ovn

  ovsdbapp, neutron, and networking-ovn all directly set
  'table.condition' which is kinda-sorta not really public API. The type
  of this variable changed with
  https://github.com/openvswitch/ovs/commit/46d44cf3be0dbf4a44cebea3b279b3d16a326796
  and there has been some breakage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-ovn/+bug/1965819/+subscriptions