[Bug 1946787] Re: [SRU] Fix inconsistent encoding secret encoding

[Corey Bryant]

A new version of barbican with this fix has been uploaded to the hirsute unapproved queue:
https://launchpad.net/ubuntu/hirsute/+queue?queue_state=1&queue_text=barbican

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to barbican in Ubuntu.
https://bugs.launchpad.net/bugs/1946787

Title:
  [SRU] Fix inconsistent encoding secret encoding

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive wallaby series:
  Triaged
Status in Ubuntu Cloud Archive xena series:
  Fix Released
Status in barbican package in Ubuntu:
  Fix Released
Status in barbican source package in Hirsute:
  Triaged
Status in barbican source package in Impish:
  Fix Released

Bug description:
  [Impact]
  This SRU corresponds with the following story for upstream barbican
  https://storyboard.openstack.org/#!/story/2008335.

  The problem is some secrets were stored in plaintext and some were
  stored encoded. This resulted in the inability to decode some secrets.

  This is fixed by always storing secrets in plaintext and decoding
  inconsistently stored data as needed when getting secrets.

  [Test Case]
  TBD

  [Where things could go wrong]
  If things were to go wrong it would probably be in the get_secret() method which calls _ensure_legacy_base64(). _ensure_legacy_base64() assumes that anything that is not a key was stored base64 encoded. Presumably this is correct, but there was a path added to catch a UnicodeDecodeError exception to handle unexpected non-base64-encoded secrets.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1946787/+subscriptions