[Bug 1916715] Re: fails on install due to systemd-service/sysv-service mismatch and lack of mkdir

[Billy Olsen]

Hi Christian,

Thanks for the feedback, I see the error I made here. I confused this
bug with bug #1865037, which actually adds the
ConditionVirtualization=!container directive to the service file but was
wrapped in the changelog. That's the change that needs to be made for
focal so I'll do some bug tidying here.

The recreate is simple - launch a new focal container and try to install
python3-rtslib-fb inside it, but I'll move this over to the proper bug.

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to python-rtslib-fb in Ubuntu.
https://bugs.launchpad.net/bugs/1916715

Title:
  fails on install due to systemd-service/sysv-service mismatch and lack
  of mkdir

Status in python-rtslib-fb package in Ubuntu:
  Fix Released
Status in python-rtslib-fb source package in Focal:
  Confirmed
Status in python-rtslib-fb source package in Groovy:
  Fix Released

Bug description:
  [Impact]
  ========

  The python3-rtslib-fb package fails to install.

  On install:

  Setting up python3-rtslib-fb (2.1.74-0ubuntu1) ...
  Job for rtslib-fb-targetctl.service failed because the control process exited with error code.
  See "systemctl status rtslib-fb-targetctl.service" and "journalctl -xe" for details.
  invoke-rc.d: initscript rtslib-fb-targetctl, action "start" failed.
  ● rtslib-fb-targetctl.service - LSB: Start LIO targets
       Loaded: loaded (]8;;file://autopkgtest/etc/init.d/rtslib-fb-targetctl/etc/init.d/rtslib-fb-targetctl]8;;; generated)
       Active: failed (Result: exit-code) since Tue 2021-02-23 18:03:16 UTC; 10ms ago
         Docs: ]8;;man:systemd-sysv-generator(8)man:systemd-sysv-generator(8)]8;;
      Process: 3296 ExecStart=/etc/init.d/rtslib-fb-targetctl start (code=exited, status=1/FAILURE)

  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3308]:     errors = RTSRoot().restore_from_file(restore_file=from_file)
  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3308]:   File "/usr/lib/python3/dist-packages/rtslib_fb/root.py", line 88, in __init__
  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3308]:     self._set_dbroot()
  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3308]:   File "/usr/lib/python3/dist-packages/rtslib_fb/root.py", line 182, in _set_dbroot
  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3308]:     raise RTSLibError("Cannot set dbroot to {}. Please check if this directory exists."
  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3308]: rtslib_fb.utils.RTSLibError: Cannot set dbroot to /etc/rtslib-fb-target. Please check if this directory exists.
  Feb 23 18:03:16 autopkgtest rtslib-fb-targetctl[3296]:    ...fail!
  Feb 23 18:03:16 autopkgtest systemd[1]: rtslib-fb-targetctl.service: Control process exited, code=exited, status=1/FAILURE
  Feb 23 18:03:16 autopkgtest systemd[1]: rtslib-fb-targetctl.service: Failed with result 'exit-code'.
  Feb 23 18:03:16 autopkgtest systemd[1]: Failed to start LSB: Start LIO targets.
  dpkg: error processing package python3-rtslib-fb (--configure):
   installed python3-rtslib-fb package post-installation script subprocess returned error exit status 1

  [Test Plan]
  ===========

  To reproduce this bug, simply do the following:

  $ lxc launch ubuntu-daily:groovy python-rtslib-fb-lp1916715-groovy

  $ lxc shell python-rtslib-fb-lp1916715-groovy

  [or shoot up a VM running Groovy]

  # apt update && apt upgrade && apt install linux-modules-
  extra-5.8.0-44-generic

  # reboot

  # apt install python3-rtslib-fb

  ...and this should fail to install.

  To make sure that this bug is indeed fixed, install the patched
  version of this package and that should install fine.

  Furthermore, check systemctl status rtslib-fb-targetctl.service and
  that should not report any problems.

  
  [Where problems could occur]
  ============================

  If someone has manually fixed the old service (manual mkdir, enable
  it, ...) or any such thing, then the fix might cause the update to
  behave a bit differently.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-rtslib-fb/+bug/1916715/+subscriptions