[Bug 1908375] Re: ceph-volume lvm list <device> calls blkid numerous times for differrent devices

[Dariusz Gadomski]

I have verified the package in 2 ways:
* manually (no traces of blkid calls in the log)
* automated - by using juju charms to set up a ceph deployment

In both cases there were no issues, no regressions noticed.

Verification is successful.

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list <device> calls blkid numerous times for
  differrent devices

Status in Ubuntu Cloud Archive:
  New
Status in Ubuntu Cloud Archive queens series:
  New
Status in ceph package in Ubuntu:
  Fix Released
Status in ceph source package in Bionic:
  Fix Committed
Status in ceph source package in Focal:
  Fix Released
Status in ceph source package in Groovy:
  Fix Released

Bug description:
  [Impact]

   * Every ceph-volume list lvm <device> call invokes blkid for numerous PARTUUIDs. For some setups with many slower IO devices this can make this call to run for minutes without any actual justification for that.
  In fact, the upstream ceph approach changed in this matter and post-bionic releases already have ceph-volume that does not invoke blkid at all in this context making the call much faster.

  Please examine the attached ceph-volume.log fragment for a ceph-volume
  call, the accumulated blkid calls take around 1 min 7 s.

  [Test Case]

   * Setup a ceph-osd with numerous block devices with long access time for blkid. Preferably use automation tools like juju (with ceph charm) or ansible to make sure ceph-volume calls work well when automated.
   * Run
  time ceph-volume --log-path ceph-volume.log --log-level debug lvm list <device>
  on one of them and check the log to see if the execution time is not wasted on numerous blkid calls.

  [Where problems could occur]

   * The output format of does not change. The only noticeable change
  will be visible in the (created on request with the --log-level --log-
  path switched) log file. Such log will also be missing the blkid
  calls. I don't see a reason for parsing that log file, but if any
  system (like CI) is doing that it may need a manual intervention to
  update its expected result.

  [Other Info]

   * The fix to this is available for Focal and beyond.
   * Xenial is not affected due to lack of ceph-volume in its ceph release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions