[Bug 1908375] Proposed package upload rejected

[Łukasz Zemczak]

An upload of ceph to bionic-proposed has been rejected from the upload
queue for the following reason: "The upload includes some garbage files,
e.g. */series.orig leftovers - please clean those up and re-upload.
Also, before we go on with accepting the upload, I wanted to know if
Chris's concerns regarding the test case have been addressed - is it now
sufficient enough? Since I don't have the required expertise, I'd like
someone from the OS team to give a +1 on that before we proceed as the
patchset is indeed quite big.".

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list <device> calls blkid numerous times for
  differrent devices

Status in Ubuntu Cloud Archive:
  New
Status in Ubuntu Cloud Archive queens series:
  New
Status in ceph package in Ubuntu:
  Fix Released
Status in ceph source package in Bionic:
  In Progress
Status in ceph source package in Focal:
  Fix Released
Status in ceph source package in Groovy:
  Fix Released

Bug description:
  [Impact]

   * Every ceph-volume list lvm <device> call invokes blkid for numerous PARTUUIDs. For some setups with many slower IO devices this can make this call to run for minutes without any actual justification for that.
  In fact, the upstream ceph approach changed in this matter and post-bionic releases already have ceph-volume that does not invoke blkid at all in this context making the call much faster.

  Please examine the attached ceph-volume.log fragment for a ceph-volume
  call, the accumulated blkid calls take around 1 min 7 s.

  [Test Case]

   * Setup a ceph-osd with numerous block devices with long access time for blkid. Preferably use automation tools like juju (with ceph charm) or ansible to make sure ceph-volume calls work well when automated.
   * Run
  time ceph-volume --log-path ceph-volume.log --log-level debug lvm list <device>
  on one of them and check the log to see if the execution time is not wasted on numerous blkid calls.

  [Where problems could occur]

   * Although a potential fix does not introduce any changes to how
  ceph-volume is used any automation depending on ceph-volume log
  parsing may notice a change.

  [Other Info]

   * The fix to this is available for Focal and beyond.
   * Xenial is not affected due to lack of ceph-volume in its ceph release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1908375/+subscriptions