[Bug 1909399] Re: Exception during removal of OSD blacklist entries

[Thorbjørn Weidemann]

Inventory needed in above comment.

** Attachment added: "ansible inventory"
   https://bugs.launchpad.net/ubuntu/+source/ceph-iscsi/+bug/1909399/+attachment/5449257/+files/inventory

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/1909399

Title:
  Exception during removal of OSD blacklist entries

Status in ceph-iscsi package in Ubuntu:
  Incomplete

Bug description:
  Ubuntu 20.04, official Ubuntu packages, ceph 15.2.7-0ubuntu0.20.04.1, ceph-iscsi 3.4-0ubuntu2
  See stacktrace below.
  Looking at the code I'm guessing this is related to https://stackoverflow.com/questions/33054527/typeerror-a-bytes-like-object-is-required-not-str-when-writing-to-a-file-in
  ie. binary vs. text
  I'm not a python programmer, but from the stackoverflow article it would seem that the output of subprocess.check_output is considered binary in python3, and a backwards compatible fix would be do .encode() the strings constants "un-blacklisting" and "isn't blacklisted".

  Dec 26 09:19:09 ff-ceph-2 rbd-target-api[8886]: Started the configuration object watcher
  Dec 26 09:19:09 ff-ceph-2 rbd-target-api[8886]: Processing osd blacklist entries for this node
  Dec 26 09:19:09 ff-ceph-2 rbd-target-api[8886]: Checking for config object changes every 1s
  Dec 26 09:19:10 ff-ceph-2 rbd-target-api[8886]: Removing blacklisted entry for this host : 192.168.1.61:6819/881
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]: Traceback (most recent call last):
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:   File "/usr/bin/rbd-target-api", line 2952, in <module>
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:     main()
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:   File "/usr/bin/rbd-target-api", line 2862, in main
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:     osd_state_ok = ceph_gw.osd_blacklist_cleanup()
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:   File "/usr/lib/python3/dist-packages/ceph_iscsi_config/gateway.py", line 110, in osd_blacklist_cleanup
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:     rm_ok = self.ceph_rm_blacklist(blacklist_entry.split(' ')[0])
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:   File "/usr/lib/python3/dist-packages/ceph_iscsi_config/gateway.py", line 46, in ceph_rm_blacklist
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]:     if ("un-blacklisting" in result) or ("isn't blacklisted" in result):
  Dec 26 09:19:12 ff-ceph-2 rbd-target-api[8886]: TypeError: a bytes-like object is required, not 'str'
  Dec 26 09:19:12 ff-ceph-2 systemd[1]: rbd-target-api.service: Main process exited, code=exited, status=1/FAILURE
  Dec 26 09:19:12 ff-ceph-2 systemd[1]: rbd-target-api.service: Failed with result 'exit-code'.
  Dec 26 09:19:12 ff-ceph-2 systemd[1]: rbd-target-api.service: Scheduled restart job, restart counter is at 1.
  Dec 26 09:19:12 ff-ceph-2 systemd[1]: Stopped Ceph iscsi target configuration API.
  Dec 26 09:19:12 ff-ceph-2 systemd[1]: Started Ceph iscsi target configuration API.

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: ceph-iscsi (not installed)
  ProcVersionSignature: Ubuntu 5.4.0-58.64-generic 5.4.73
  Uname: Linux 5.4.0-58-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27.14
  Architecture: amd64
  CasperMD5CheckResult: pass
  Date: Sun Dec 27 12:17:49 2020
  InstallationDate: Installed on 2020-12-24 (2 days ago)
  InstallationMedia: Ubuntu-Server 20.04.1 LTS "Focal Fossa" - Release amd64 (20200731)
  SourcePackage: ceph-iscsi
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph-iscsi/+bug/1909399/+subscriptions