[Bug 1914100] Re: python3-heat-dashboard launch stack fails

[Heather Lemon]

** Description changed:

  Heat-dashboard fails to upload files.
  
  [Impact]
  
  Users cannot upload heat template files via the Openstack dashboard (see
  failed ui screenshot)
  
  "A template is used to automate the deployment of infrastructure,
  services, and applications."
  
  [Test Case]
  
  1) Setup a basic openstack with heat and horizon
  - generate a heat-template.yaml deployment (attached template.yaml)
  2) After the regular cloud setup, try to upload the file via horizon dashboard -> Project -> Stacks -> Launch stack (+)
  - choose the template.yaml
  3) Check openstack-dashboard /var/log/apache2/error.log and it should have the error
  ```
  [Mon Feb 01 19:46:05.787127 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]   File "/usr/lib/python3/dist-packages/heat_dashboard/content/stacks/forms.py", line 149, in clean
  [Mon Feb 01 19:46:05.787129 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]     self.clean_uploaded_files('template', _('template'), cleaned, files)
  [Mon Feb 01 19:46:05.787132 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]   File "/usr/lib/python3/dist-packages/heat_dashboard/content/stacks/forms.py", line 207, in clean_uploaded_files
  [Mon Feb 01 19:46:05.787135 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]     if tpl.startswith('{'):
  [Mon Feb 01 19:46:05.787139 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180] TypeError: startswith first arg must be bytes or a tuple of bytes, not str
- [Mon Feb 01 19:46:05.787145 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180] 
+ [Mon Feb 01 19:46:05.787145 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]
  ```
  
  [Where problems could occur]
  
  The information for the forms page could fail to load properly.
  
  [Other Info]
  
+ Patch landed in train and now going to stein. 
+ Since focal is carry 2.0 which has the fix, no need to add the ubuntu bionic package series. 
+ 
  Openstack: Stein
  OS: Ubuntu Bionic

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1914100

Title:
  python3-heat-dashboard launch stack fails

Status in Ubuntu Cloud Archive:
  Invalid
Status in Ubuntu Cloud Archive stein series:
  In Progress
Status in heat-dashboard package in Ubuntu:
  Invalid

Bug description:
  Heat-dashboard fails to upload files.

  [Impact]

  Users cannot upload heat template files via the Openstack dashboard
  (see failed ui screenshot)

  "A template is used to automate the deployment of infrastructure,
  services, and applications."

  [Test Case]

  1) Setup a basic openstack with heat and horizon
  - generate a heat-template.yaml deployment (attached template.yaml)
  2) After the regular cloud setup, try to upload the file via horizon dashboard -> Project -> Stacks -> Launch stack (+)
  - choose the template.yaml
  3) Check openstack-dashboard /var/log/apache2/error.log and it should have the error
  ```
  [Mon Feb 01 19:46:05.787127 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]   File "/usr/lib/python3/dist-packages/heat_dashboard/content/stacks/forms.py", line 149, in clean
  [Mon Feb 01 19:46:05.787129 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]     self.clean_uploaded_files('template', _('template'), cleaned, files)
  [Mon Feb 01 19:46:05.787132 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]   File "/usr/lib/python3/dist-packages/heat_dashboard/content/stacks/forms.py", line 207, in clean_uploaded_files
  [Mon Feb 01 19:46:05.787135 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]     if tpl.startswith('{'):
  [Mon Feb 01 19:46:05.787139 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180] TypeError: startswith first arg must be bytes or a tuple of bytes, not str
  [Mon Feb 01 19:46:05.787145 2021] [wsgi:error] [pid 13984:tid 140255296943872] [remote 10.5.3.109:59180]
  ```

  [Where problems could occur]

  The information for the forms page could fail to load properly.

  [Other Info]

  Patch landed in train and now going to stein. 
  Since focal is carry 2.0 which has the fix, no need to add the ubuntu bionic package series. 

  Openstack: Stein
  OS: Ubuntu Bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1914100/+subscriptions