[Bug 1773765] Fix merged to masakari (stable/ussuri)

[OpenStack Infra]

Reviewed:  https://review.opendev.org/753921
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=b53155b314068a46cd097d3788add1b6d4fc0aff
Submitter: Zuul
Branch:    stable/ussuri

commit b53155b314068a46cd097d3788add1b6d4fc0aff
Author: suzhengwei <sugar-2008 at 163.com>
Date:   Fri Apr 17 08:59:35 2020 +0800

    check expired notifications
    
    Occasionally, there would be notifications which will remain 'new',
    'error' or 'running' status all times, and not to be processed again.
    Due to this, operator can not update the segment or host.
    
    This patch add one task to periodically check unfinished notifications.
    If one unfinished notification is expired, just set its status to
    'failed'.
    
    Close-Bug: #1773765
    Change-Id: If49635639dd976aeec3ea73e702ad2636fcf1e0a
    (cherry picked from commit 3a4f782441f6bdcfb8ee49a393937267fc246c56)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to masakari in Ubuntu.
https://bugs.launchpad.net/bugs/1773765

Title:
  There is a possibility that 'running' notification will remain

Status in masakari:
  Fix Released
Status in masakari package in Ubuntu:
  New

Bug description:
  masakari-engine has two periodic tasks, one for processing 'new'
  notifications and the other for processing 'error' notifications But
  it doesn't have a periodic task for processing 'running'
  notifications.

  Looking at the code of masakari-engine, if the process of it goes down
  immediately after it changes notification status from 'new' to
  'running', then the notification which status is 'running' will remain
  will not be processed by periodic tasks.

  So, should masakari-engine's periodic task process the 'running' notification?
  (Although it need to make such a logic that main process doesn't compete with periodic tasks.)
  Or should the 'running' notification be handled by the operator?

To manage notifications about this bug go to:
https://bugs.launchpad.net/masakari/+bug/1773765/+subscriptions