[Bug 1894453] Re: Building Ceph packages with RelWithDebInfo

[Ponnuvel Palaniyappan]

Looking some of the recent build logs, most of the Ceph packages are in
fact compiled with -O2 and -g as Trent alluded to. Only rocksdb is
compiled without them as Tyler noted.

However, the upstream rocksdbhas been changed to honour CMAKE_BUILD_TYPE
recently [2]. So it's only the rocksdb in UCA that appear to be old;
src/rocksdb/CMakeLists.txt [3] is different from the one in UCA [5]. So
I believe that source rocksdb needs to be updated to use latest version
and that'd naturally build rocksdb RelWithDebInfo, too, as upstream
already has the changes for that.


[0] https://launchpadlibrarian.net/475127725/buildlog_ubuntu-focal-amd64.ceph_15.2.1-0ubuntu1_BUILDING.txt.gz

[1] https://launchpadlibrarian.net/494025636/buildlog_ubuntu-groovy-
amd64.ceph_15.2.3-0ubuntu3_BUILDING.txt.gz

[2] https://github.com/facebook/rocksdb/pull/5916/files

[3]
https://github.com/ceph/rocksdb/blob/f86d378860f399bf595bd1135f39f03a9eaca59f/CMakeLists.txt

[4]
https://git.launchpad.net/ubuntu/+source/ceph/tree/src/rocksdb/CMakeLists.txt

[5]
https://git.launchpad.net/ubuntu/+source/ceph/tree/src/rocksdb/CMakeLists.txt

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph in Ubuntu.
https://bugs.launchpad.net/bugs/1894453

Title:
  Building Ceph packages with RelWithDebInfo

Status in ceph package in Ubuntu:
  In Progress

Bug description:
  This is to consider/discuss the possibility of whether the Ceph
  packages (UCA) should be built with RelWithDebInfo build option
  (CMAKE_BUILD_TYPE [0]) which can be supplied to the build script
  do_cmake.sh [1].

  Currently, Upstream as well as UCA builds default to 'Debug' [0]
  builds. But is any reason why shouldn't go for RelWithDebInfo (i.e.
  "Release with Debug information")?

  
  There's one issue noted with RelWithDebInfo which has a workaround too [2].

  In general, gcc's -O2 [3] build should generate better code as well as
  there's a specific case for Ceph [4] that it improves performance.

  [0] https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html

  [1] https://github.com/ceph/ceph/blob/master/do_cmake.sh

  [2] https://docs.ceph.com/docs/master/dev/perf/#common-issues

  [3] https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html

  [4] https://bugs.gentoo.org/show_bug.cgi?id=733316

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453/+subscriptions