[Bug 1865037] Re: make the service fail gracefully if unable to load modules

[Rafael David Tinoco]

CURRENT STATUS

Targets:

- I: ceph-iscsi

- II: targetcli-fb

Summary for the current state:

I: ceph-iscsi
    [-] MIR ack (if everything else is)

I/II: python-configshell-fb
    [.] MIR ack
    [.] Security ack - needs DEP8 inclusion

    Suggesting:
    - https://salsa.debian.org/linux-blocks-team/python-configshell-fb/-/merge_requests/3/

II: targetcli-fb
    [.] MIR ack - needs DEP8 and services/sockets fix
    [.] Security nack->ack - 2 upstream fixes done

    Suggesting:
    - https://salsa.debian.org/linux-blocks-team/targetcli-fb/-/merge_requests/8
    
I/II: python-rtslib-fb
    [.] MIR ack - needs packaging/lintian fixes
    [.] Security ack - upstream fix done

    - Upstream version v2.1.73 incudes the security fix.
    
    Suggesting:
    https://salsa.debian.org/openstack-team/python/python-rtslib-fb/-/merge_requests/2
    https://salsa.debian.org/openstack-team/python/python-rtslib-fb/-/merge_requests/3
    
    - Might not need fix for LP: #1865037 (put a comment, waiting Debian)
    - Highlighted @jamespage in both MR in salsa (hopefully he can help)

I: tcmu
    [.] MIR ack
    [+] Security ack - but needs dbus fix

I: urwid
    [.] MIR ack
    [.] Security: ack

Only thing missing: tcmu fix and wait changes to be accepted so we can
put all those packages on sync (and then do the MIR if everybody is on
the same page).

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to python-rtslib-fb in Ubuntu.
https://bugs.launchpad.net/bugs/1865037

Title:
  make the service fail gracefully if unable to load modules

Status in rtslib-fb:
  Unknown
Status in python-rtslib-fb package in Ubuntu:
  Triaged

Bug description:
  The LIO interfaces is inherently tied to the kernel.
  That makes the service fail on e.g. a container install:

  See "systemctl status rtslib-fb-targetctl.service" and "journalctl -xe" for details.
  root at f:~# systemctl status rtslib-fb-targetctl.service
  ● rtslib-fb-targetctl.service - Restore LIO kernel target configuration
       Loaded: loaded (/lib/systemd/system/rtslib-fb-targetctl.service; disabled; vendor preset: enabled)
       Active: failed (Result: exit-code) since Thu 2020-02-27 14:10:35 UTC; 3s ago
      Process: 23831 ExecStart=/usr/bin/mkdir -p /etc/rtslib-fb-target (code=exited, status=0/SUCCESS)
      Process: 23832 ExecStart=/usr/bin/targetctl restore (code=exited, status=1/FAILURE)
     Main PID: 23832 (code=exited, status=1/FAILURE)

  Feb 27 14:10:35 f target[23832]:   File "/usr/bin/targetctl", line 47, in restore
  Feb 27 14:10:35 f target[23832]:     errors = RTSRoot().restore_from_file(restore_file=from_file)
  Feb 27 14:10:35 f target[23832]:   File "/usr/lib/python3/dist-packages/rtslib_fb/root.py", line 85, in __init__
  Feb 27 14:10:35 f target[23832]:     modprobe('target_core_mod')
  Feb 27 14:10:35 f target[23832]:   File "/usr/lib/python3/dist-packages/rtslib_fb/utils.py", line 428, in modprobe
  Feb 27 14:10:35 f target[23832]:     raise RTSLibError(stderrdata)
  Feb 27 14:10:35 f target[23832]: rtslib_fb.utils.RTSLibError: b"modprobe: ERROR: ../libkmod/libkmod.c:611 kmod_search_moddep() could not open moddep file '/lib/modules/5.3.0-40-generic/modu>
  Feb 27 14:10:35 f systemd[1]: rtslib-fb-targetctl.service: Main process exited, code=exited, status=1/FAILURE
  Feb 27 14:10:35 f systemd[1]: rtslib-fb-targetctl.service: Failed with result 'exit-code'.
  Feb 27 14:10:35 f systemd[1]: Failed to start Restore LIO kernel target configuration.

  
  It is ok that this doesn't work in a container, but it also breaks the package installation status which should be avoided.

  Until a more fine grained detection is developed that could be as easy as adding:
    ConditionVirtualization=!container

  That would let the package install, but not start the service (knowing
  it would fail).

To manage notifications about this bug go to:
https://bugs.launchpad.net/rtslib-fb/+bug/1865037/+subscriptions