[Bug 1880959] Re: Rules from the policy directory files are not reapplied after changes to the primary policy file
Dmitrii Shcherbakov
1880959 at bugs.launchpad.net
Fri Jul 31 11:40:44 UTC 2020
Verified xenial/queens (the updated packages got uploaded compared to
the check in comment #45):
lxc launch ubuntu:xenial oslop-xq
Creating oslop-xq
Starting oslop-xq
lxc exec oslop-bq bash
root at oslop-xq:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.6 LTS
Release: 16.04
Codename: xenial
root at oslop-xq:~# apt update
root at oslop-xq:~# apt install ubuntu-cloud-keyring
root at oslop-xq:~# sudo add-apt-repository cloud-archive:queens-proposed
root at oslop-xq:~# cat /etc/apt/sources.list.d/cloudarchive-queens-proposed.list
deb http://ubuntu-cloud.archive.canonical.com/ubuntu xenial-proposed/queens main
# deb-src http://ubuntu-cloud.archive.canonical.com/ubuntu xenial-proposed/queens main
root at oslop-xq:~# apt update && apt install python3-oslo.policy python-oslo.policy python3-oslotest python-oslotest
Setting up python-oslo.policy (1.33.1-0ubuntu3~cloud0) ...
Setting up python3-oslo.policy (1.33.1-0ubuntu3~cloud0) ...
root at oslop-xq:/usr/lib/python2.7/dist-packages/oslo_policy# dpkg -l | grep oslo.policy
ii python-oslo.policy 1.33.1-0ubuntu3~cloud0 all RBAC policy enforcement library for OpenStack - Python 2.x
ii python3-oslo.policy 1.33.1-0ubuntu3~cloud0 all RBAC policy enforcement library for OpenStack - Python 3.x
root at oslop-xq:~# cd /usr/lib/python3/dist-packages/oslo_policy/
root at oslop-xq:/usr/lib/python3/dist-packages/oslo_policy# PYTHONPATH=`realpath tests` ; python3 -m unittest tests.test_policy.EnforcerTest.test_load_directory_after_file_update
WARNING [oslo_policy.policy] Policies ['foo'] reference a rule that is not defined.
.
----------------------------------------------------------------------
Ran 1 test in 0.086s
OK
root at oslop-xq:/usr/lib/python3/dist-packages/oslo_policy# cd /usr/lib/python2.7/dist-packages/oslo_policy
root at oslop-xq:/usr/lib/python2.7/dist-packages/oslo_policy#
root at oslop-xq:/usr/lib/python2.7/dist-packages/oslo_policy# PYTHONPATH=`realpath tests` ; python -m unittest tests.test_policy.EnforcerTest.test_load_directory_after_file_update
WARNING [oslo_policy.policy] Policies [u'foo'] reference a rule that is not defined.
.
----------------------------------------------------------------------
Ran 1 test in 0.079s
OK
** Tags removed: verification-needed verification-queens-needed
** Tags added: verification-done verification-queens-done
--
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1880959
Title:
Rules from the policy directory files are not reapplied after changes
to the primary policy file
Status in Ubuntu Cloud Archive:
Fix Released
Status in Ubuntu Cloud Archive mitaka series:
Won't Fix
Status in Ubuntu Cloud Archive queens series:
Fix Committed
Status in Ubuntu Cloud Archive rocky series:
Fix Released
Status in Ubuntu Cloud Archive stein series:
Fix Released
Status in Ubuntu Cloud Archive train series:
Fix Released
Status in Ubuntu Cloud Archive ussuri series:
Fix Released
Status in oslo.policy:
Fix Released
Status in python-oslo.policy package in Ubuntu:
Fix Released
Status in python-oslo.policy source package in Xenial:
Won't Fix
Status in python-oslo.policy source package in Bionic:
Fix Committed
Status in python-oslo.policy source package in Eoan:
Won't Fix
Status in python-oslo.policy source package in Focal:
Fix Released
Status in python-oslo.policy source package in Groovy:
Fix Released
Bug description:
[Impact]
Based on the investigation here https://bugs.launchpad.net/charm-keystone/+bug/1880847 it was determined that rules from policy files located in the directory specified in the policy_dirs option (/etc/<config_dir>/policy.d by default) are not re-applied after the rules from the primary policy file is re-applied due to a change.
This leads to scenarios where incorrect rule combinations are active.
Example from the test case in 1880847:
* policy.json gets read with the following rule;
"identity:list_credentials": "rule:admin_required or user_id:%(user_id)s",
* rule.yaml from policy.d is read with the following rule;
{'identity:list_credentials': '!'}
* policy.json's mtime gets updated (with or without a content change) and overrides the rule to be
"identity:list_credentials": "rule:admin_required or user_id:%(user_id)s",
* rule.yaml doesn't get reapplied since it hasn't changed.
[Test Case]
== ubuntu ==
The patches include unit tests that ensure the code is behaving as
expected and has not regressed. These tests are run during every
package build.
== upstream ==
For a particular version of oslo.policy:
* put the attached test (https://bugs.launchpad.net/ubuntu/+source
/python-
oslo.policy/+bug/1880959/+attachment/5377753/+files/test_1880959.py)
under oslo_policy/tests/test_1880959.py;
* run tox -e cover -- oslo_policy.tests.test_1880959.EnforcerTest;
* observe the failure;
# ...
testtools.matchers._impl.MismatchError: 'role:fakeA' != 'rule:admin'
Ran 1 tests in 0.005s (+0.001s)
FAILED (id=1, failures=1)
* apply the patch;
* run tox -e cover -- oslo_policy.tests.test_1880959.EnforcerTest
* observe that the failure is no longer there.
[Regression Potential]
The regression potential is low given that there is test coverage in the olso.policy unit tests.
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1880959/+subscriptions
More information about the Ubuntu-openstack-bugs
mailing list