[Bug 1884580] Re: Nova novncproxy doesnt work - unexpected keyword

[James Page]

Accepted upstream was my gate for starting the SRU process - it took me
a while to figure out what actually needed to happen in the underlying
code with regards to calling underlying un-monkey-patched code from the
Python core ssl library.  Passing the **kw arg its pretty pointless -
the wrap_socket function does not have any other args than those called
out specifically!

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to python-eventlet in Ubuntu.
https://bugs.launchpad.net/bugs/1884580

Title:
  Nova novncproxy doesnt work - unexpected keyword

Status in OpenStack nova-cloud-controller charm:
  Invalid
Status in python-eventlet package in Ubuntu:
  Fix Released
Status in python-eventlet source package in Focal:
  Fix Committed
Status in python-eventlet source package in Groovy:
  Fix Released

Bug description:
  == Impact ==

  SSL secured console access to instances in OpenStack clouds is broken.

  == Test Case ==

  Deploy OpenStack using TLS secured endpoints (juju + charms)
  Boot instance, attempt to access console via dashboard - error in web page and
  error seen in nova-novncproxy log file.

  
  == Regression Potential ==

  Medium - the fix is in eventlet's use of the SSL native library which was broken when wrapping sockets using the SSLContext class.  The fix has been
  accepted upstream and is accompanied with a test case.

  
  == Original Bug Report ==


  Ubuntu Focal (20.04)
  Openstack Ussuri (distro-proposed)
  LXC
  Nova Cloud Controller Charm Rev 68

  When attempting to view the console in Horizon (Openstack Dashboard),
  console frame returns "503 Service Unavailable", when checking the
  nova cloud controller logs for nova-novncproxy, the following error
  appears:

  2020-06-22 17:48:18.262 1463207 INFO nova.console.websocketproxy [-]
  handler exception: wrap_socket() got an unexpected keyword argument
  '_context'

  Google seems to find related issues:
  https://github.com/eventlet/eventlet/issues/526

  as well as:

  https://ask.openstack.org/en/question/127493/nova-novncproxy-fails-to-
  connect-handler-exception-wrap_socket-got-an-unexpected-keyword-
  argument-_context/

  So it seems to be an issue with Python > 3.6, but I cannot downgrade
  python version as it would break nova-novncproxy (already tried)

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-nova-cloud-controller/+bug/1884580/+subscriptions