[Bug 1773324] Re: [SRU] rabbitmqadmin shows %%VSN%% as version

[Christian Ehrhardt ]

The fix taken is mixed with some py3 changes, but it eventually was in
d/rules:

+override_dh_install:
+       dh_install
+       sed -i s/%%VSN%%/$(VERSION)/ $(CURDIR)/debian/rabbitmq-server/usr/bin/rabbitmqadmin

From:
https://salsa.debian.org/openstack-team/third-party/rabbitmq-server/-/commit/9d13c83ecab526e46d01e4250d157f2085fa43b6

Using the same change would make a later merge easier.
We can consider SRUs later, lets get this into Focal while we still can.

@Bryce - this one is still assigned to you - are you going to revamp
that for a focal upload?

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to rabbitmq-server in Ubuntu.
https://bugs.launchpad.net/bugs/1773324

Title:
  [SRU] rabbitmqadmin shows %%VSN%% as version

Status in rabbitmq-server package in Ubuntu:
  Triaged
Status in rabbitmq-server source package in Bionic:
  Triaged
Status in rabbitmq-server source package in Cosmic:
  Won't Fix
Status in rabbitmq-server source package in Disco:
  Triaged
Status in rabbitmq-server source package in Eoan:
  Triaged
Status in rabbitmq-server source package in Focal:
  Triaged
Status in rabbitmq-server package in Debian:
  Fix Released

Bug description:
  [Impact]
  Version information is displayed by rabbitmq-server, preventing configuration management tools from deploying and maintaining the services properly.

  [Test Case]
  $ rabbitmqadmin --version
  rabbitmqadmin %%VSN%%

  [Regression Potential]
  Very low.  The patch simply adds a step to the makefile.  Things to look for would be build-time related problems; none are expected.

  [Fix]
  Upstream's release scripts substitute in the version string, but that logic isn't triggered during the regular debian package build.  It's straightforward to fix by inserting an equivalent sed command to the makefile during our build.

  This issue affects rabbitmq-server from Bionic forward, and will need
  carried in our own packaging.  The fix may be worth forwarding to
  debian as well, once it's confirmed their package is affected as well.

  For testing, a PPA with packages containing the fix is available at:
  https://launchpad.net/~bryce/+archive/ubuntu/sru.1773324

  [Discussion]

  [Original Report]
  When running 'rabbitmqadmin --version' it shows %%VSN%% as the version information on Ubuntu 18.04 and not the correct rabbitmq version. We are using puppet to install and configure rabbitmq server and the puppet-rabbitmq modules [1] are using the version information from that command internally. Currently they are failing in Ubuntu 18.04.

  Used versions:

  Distributor ID: Ubuntu
  Description:    Ubuntu 18.04 LTS
  Release:        18.04
  Codename:       bionic
  rabbitmq-server: 3.6.10-1

  [1] https://github.com/voxpupuli/puppet-rabbitmq

  ProblemType: Bug
  DistroRelease: Ubuntu 18.04
  Package: rabbitmq-server 3.6.10-1
  ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
  Uname: Linux 4.15.0-20-generic x86_64
  ApportVersion: 2.20.9-0ubuntu7
  Architecture: amd64
  Date: Fri May 25 09:46:18 2018
  PackageArchitecture: all
  SourcePackage: rabbitmq-server
  UpgradeStatus: No upgrade log present (probably fresh install)
  modified.conffile..etc.default.rabbitmq-server: [modified]
  mtime.conffile..etc.default.rabbitmq-server: 2018-05-24T07:06:38.256492

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/1773324/+subscriptions