[Bug 1805332] Re: [Swift backend] Upload image hit error: Unicode-objects must be encoded before hashing

[Robie Basak]

14:09 <rbasak> coreycb: have you done a CI run against python-glance-
store as well as having verified the individual fix? I don't see any CI
report in the bug.

14:11 <coreycb> rbasak: i've not but we generally only run CI for stable
point releases. i certainly can though.

14:17 <rbasak> coreycb: the bug description  said you'd run it! I don't
mind how it's achieved but I'd prefer to have some confidence that the
SRU doesn't break existing functionality, and CI seems like a good way
to do that.

14:17 <rbasak> coreycb: especially if the bug being fixed is
particularly targeted and so the test to verify the bug fix itself
doesn't exercise much of the package, which I presume here it doesn't?

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1805332

Title:
  [Swift backend] Upload image hit error: Unicode-objects must be
  encoded before hashing

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive rocky series:
  Fix Committed
Status in Ubuntu Cloud Archive stein series:
  Fix Released
Status in glance_store:
  Triaged
Status in python-glance-store package in Ubuntu:
  Fix Released
Status in python-glance-store source package in Cosmic:
  Fix Committed
Status in python-glance-store source package in Disco:
  Fix Released
Status in python-glance-store source package in Eoan:
  Fix Released

Bug description:
  [Impact]
  If we upload a large image (larger than 1G), the glance_store will hit a Unicode error. To fix this a patch has been merged in upstream master and backported to stable rocky.

  [Test Case]
  Deploy glance related to swift-proxy using the object-store relation. Then attempt to upload a large image (not cirros)

  $ openstack image create --public --file /home/ubuntu/images/bionic-server-cloudimg-amd64.img bionic-test
  500 Internal Server Error: The server has either erred or is incapable of performing the requested operation. (HTTP 500)

  If the patch is manually applied and glance-api restarted then the
  above command succeeds.

  In order to avoid regression of existing consumers, the OpenStack team will
  run their continuous integration test against the packages that are in
  -proposed. A successful run of all available tests will be required before the
  proposed packages can be let into -updates.

  The OpenStack team will be in charge of attaching the output summary of the
  executed tests. The OpenStack team members will not mark ‘verification-done’ until
  this has happened.

  [Regression Potential]
  In order to mitigate the regression potential, the results of the
  aforementioned tests are attached to this bug.

  [Discussion]
  n/a

  [Original Description]

  env: master branch, Glance using swift backend.

  We hit a strange error， if we upload a large image (larger than 1G),
  the glance_store will hit a error:Unicode-objects must be encoded
  before hashing. But if the image is small enough, the error won't
  happen.

  error log:
  https://www.irccloud.com/pastebin/jP3DapNy/

  After dig into the code, it appears that when chunk reading the image
  data, the date piece may be non-byte, so the checksum.updating will
  raise the error.

  encoding the date piece to ensure it's byte can solve the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1805332/+subscriptions