[Bug 1826523] Re: libvirtError exceptions during volume attach leave volume connected to host

[Jorge Niedbalski]

** Description changed:

- Description
- ===========
+ [Impact]
  
- In addition to bug #1825882 where libvirtError exceptions are not raised
- correctly when attaching volumes to domains the underlying volumes are
- not disconnected from the host.
+  * This is an additional patch required for bug #1825882, when
+ a libvirt exception that prevents the volume attachment to complete,
+ the underlying volumes should be disconnected from the host.
  
- Steps to reproduce
- ==================
+ [Test Case]
  
- - virsh detach-disk <domain> vdb
- - update nova & cinder DB as if volume is detached
- - re-attach volume
+ * Deploy any OpenStack version up to Pike , which includes ceph backed cinder 
+ * Create a guest VM (openstack server ...)
+ * Create a test cinder volume
  
- Expected result
- ===============
- Volume attach fails and the volume is disconnected from the host.
+ $ openstack volume create test --size 10
  
- Actual result
- =============
- volume attach fails but remains connected to the host.
+ * Force a drop on ceph traffic. Run the following command on the nova
+ hypervisor on which the server runs.
  
- Environment
- ===========
- 1. Exact version of OpenStack you are running. See the following
-   list for all releases: http://docs.openstack.org/releases/
+ $ iptables -A OUTPUT -d ceph-mon-addr -p tcp --dport 6800 -j DROP
  
-    master to stable/queens
+ * Attach the volume to a running instance.
  
- 2. Which hypervisor did you use?
-    (For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...)
-    What's the version of that?
+ $ openstack server add volume 7151f507-a6b7-4f6d-a4cc-fd223d9feb5d
+ 742ff117-21ae-4d1b-a52b-5b37955716ff
  
-    Libvirt + QEMU/KVM
  
- 2. Which storage type did you use?
-    (For example: Ceph, LVM, GPFS, ...)
-    What's the version of that?
+ * This should cause the volume attachment to fail
  
-    N/A
+ $ virsh domblklist instance-xxxxx
+ Target Source
+ ------------------------------------------------
+ vda nova/7151f507-a6b7-4f6d-a4cc-fd223d9feb5d_disk
  
- 3. Which networking type did you use?
-    (For example: nova-network, Neutron with OpenVSwitch, ...)
  
-    N/A
+ No volume should attached after this step.
+ 
+ * If the behavior is fixed:
+ 
+    * Check that  openstack server show , doesn't displays the  displays
+ the volume as attached.
+ 
+ * If the behavior isn't fixed:
+ 
+    * openstack server show <ID> , will display the volume in the
+ volumes_attached property.
+ 
+ [Expected result]
+ 
+ * Volume attach fails and the volume is disconnected from the host.
+ 
+ [Actual result]
+ 
+ * Volume attach fails but remains connected to the host.
+ 
+ [Regression Potential]
+ 
+ * We haven't identified any regression potential on this SRU.
+ 
+ [Other Info]
+  
+ * N/A

** Tags added: sts

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to nova in Ubuntu.
https://bugs.launchpad.net/bugs/1826523

Title:
  libvirtError exceptions during volume attach leave volume connected to
  host

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) queens series:
  Fix Committed
Status in OpenStack Compute (nova) rocky series:
  Fix Committed
Status in OpenStack Compute (nova) stein series:
  Fix Committed
Status in nova package in Ubuntu:
  New
Status in nova source package in Bionic:
  New
Status in nova source package in Cosmic:
  New
Status in nova source package in Disco:
  New

Bug description:
  [Impact]

   * This is an additional patch required for bug #1825882, when
  a libvirt exception that prevents the volume attachment to complete,
  the underlying volumes should be disconnected from the host.

  [Test Case]

  * Deploy any OpenStack version up to Pike , which includes ceph backed cinder 
  * Create a guest VM (openstack server ...)
  * Create a test cinder volume

  $ openstack volume create test --size 10

  * Force a drop on ceph traffic. Run the following command on the nova
  hypervisor on which the server runs.

  $ iptables -A OUTPUT -d ceph-mon-addr -p tcp --dport 6800 -j DROP

  * Attach the volume to a running instance.

  $ openstack server add volume 7151f507-a6b7-4f6d-a4cc-fd223d9feb5d
  742ff117-21ae-4d1b-a52b-5b37955716ff

  
  * This should cause the volume attachment to fail

  $ virsh domblklist instance-xxxxx
  Target Source
  ------------------------------------------------
  vda nova/7151f507-a6b7-4f6d-a4cc-fd223d9feb5d_disk

  
  No volume should attached after this step.

  * If the behavior is fixed:

     * Check that  openstack server show , doesn't displays the
  displays the volume as attached.

  * If the behavior isn't fixed:

     * openstack server show <ID> , will display the volume in the
  volumes_attached property.

  [Expected result]

  * Volume attach fails and the volume is disconnected from the host.

  [Actual result]

  * Volume attach fails but remains connected to the host.

  [Regression Potential]

  * We haven't identified any regression potential on this SRU.

  [Other Info]
   
  * N/A

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1826523/+subscriptions