[Bug 1805332] Proposed package upload rejected

[Łukasz Zemczak]

An upload of python-glance-store to disco-proposed has been rejected
from the upload queue for the following reason: "SRU test case seems a
bit insufficient: it is a very good idea to request a full CI run for
the packages, but it doesn't feel sufficient for checking if the target
bug is fixed. The added patch doesn't come with any tests, so the upload
should come with a test-case trying to test if the actual regression has
been fixed. Also, simply wondering: the cherry-picked fix has been named
a 'band-aid fix', with the underlying issue still needing fixing - is
there still no full fix for this?".

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1805332

Title:
  [Swift backend] Upload image hit error: Unicode-objects must be
  encoded before hashing

Status in Ubuntu Cloud Archive:
  Triaged
Status in Ubuntu Cloud Archive rocky series:
  Triaged
Status in Ubuntu Cloud Archive stein series:
  Triaged
Status in glance_store:
  Triaged
Status in python-glance-store package in Ubuntu:
  Fix Released
Status in python-glance-store source package in Disco:
  In Progress
Status in python-glance-store source package in Eoan:
  Fix Released

Bug description:
  [Impact]
  If we upload a large image (larger than 1G), the glance_store will hit a Unicode error. To fix this a patch has been merged in upstream master and backported to stable rocky.

  [Test Case]
  In order to avoid regression of existing consumers, the OpenStack team will
  run their continuous integration test against the packages that are in
  -proposed. A successful run of all available tests will be required before the
  proposed packages can be let into -updates.

  The OpenStack team will be in charge of attaching the output summary of the
  executed tests. The OpenStack team members will not mark ‘verification-done’ until
  this has happened.

  [Regression Potential]
  In order to mitigate the regression potential, the results of the
  aforementioned tests are attached to this bug.

  [Discussion]
  n/a

  [Original Description]

  env: master branch, Glance using swift backend.

  We hit a strange error， if we upload a large image (larger than 1G),
  the glance_store will hit a error:Unicode-objects must be encoded
  before hashing. But if the image is small enough, the error won't
  happen.

  error log:
  https://www.irccloud.com/pastebin/jP3DapNy/

  After dig into the code, it appears that when chunk reading the image
  data, the date piece may be non-byte, so the checksum.updating will
  raise the error.

  encoding the date piece to ensure it's byte can solve the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1805332/+subscriptions