[Bug 1804062] Related fix merged to nova (master)

[OpenStack Infra]

Reviewed:  https://review.opendev.org/664622
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=18ba6e6e6a7d1294bd1f1ece454f84eb65b219bb
Submitter: Zuul
Branch:    master

commit 18ba6e6e6a7d1294bd1f1ece454f84eb65b219bb
Author: Eric Fried <openstack at fried.cc>
Date:   Tue Jun 11 10:24:11 2019 -0500

    Skip test_check_doubled_words hacking check UT
    
    The referenced bug has reared its ugly head in python 2.7.15 in (at
    least) releaselevel='final', which is being used in the gate, as well as
    3.6.7+. Disable the test entirely until we can fix or work around the
    bug in the tokenizer.
    
    The hacking check itself is still in place. This is just disabling the
    unit test that tries to test the hacking check.
    
    NOTE: Noticed that the hacking check is operating on physical_line,
    which means it'll catch things like:
    
     "This is the the error"
    
    but not:
    
     ("This is the "
      "the error")
    
    ...which is probably way more likely.
    
    Change-Id: I8826c3fb89690805baae6b9b7b48985abb8d62d3
    Related-Bug: #1804062

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1804062

Title:
  test_hacking fails for python 3.6.7 and newer

Status in Ubuntu Cloud Archive:
  Triaged
Status in Ubuntu Cloud Archive queens series:
  Triaged
Status in Ubuntu Cloud Archive rocky series:
  Triaged
Status in Ubuntu Cloud Archive stein series:
  Triaged
Status in masakari:
  New
Status in OpenStack Compute (nova):
  Confirmed
Status in nova package in Ubuntu:
  Triaged
Status in nova source package in Bionic:
  Triaged
Status in nova source package in Cosmic:
  Triaged
Status in nova source package in Disco:
  Triaged
Status in nova source package in Eoan:
  Triaged

Bug description:
  The check for double words in test_hacking is failing in python 3.6.7
  (released in ubuntu 18.04 within the last few days) and in new
  versions of 3.7.x. This is is because of this change to python:
  https://bugs.python.org/issue33899 .

  This is causing failures in python 36 unit tests for nova.

  The fix ought to be adding a newline to the code sample. Maybe.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1804062/+subscriptions