[Bug 1835354] Re: disco: ceph-mgr unable to load crash module under py3

[David Coronel]

Tested packages from stein-proposed on ceph-mon units:

BEFORE:

root at juju-1101fd-18-lxd-0:~# ceph -s
  cluster:
    id:     832cb0a6-a3e7-11e9-bedc-00163e7eca36
    health: HEALTH_WARN
            Module 'crash' has failed dependency: invalid syntax (module.py, line 48)
[...]

root at juju-1101fd-18-lxd-0:/var/log/ceph# grep crash *
[...]
ceph.log:2019-07-16 15:00:00.000113 mon.juju-1101fd-19-lxd-0 mon.0 10.191.4.29:6789/0 20888 : cluster [WRN] overall HEALTH_WARN Module 'crash' has failed dependency: invalid syntax (module.py, line 48)
ceph.log:2019-07-16 16:00:00.000185 mon.juju-1101fd-19-lxd-0 mon.0 10.191.4.29:6789/0 21040 : cluster [WRN] overall HEALTH_WARN Module 'crash' has failed dependency: invalid syntax (module.py, line 48)
[...]

AFTER:

root at juju-1101fd-18-lxd-0:/var/log/ceph# ceph -s
  cluster:
    id:     832cb0a6-a3e7-11e9-bedc-00163e7eca36
    health: HEALTH_OK

root at juju-1101fd-18-lxd-0:/var/log/ceph# dpkg -l | grep ceph
ii  ceph                           13.2.6-0ubuntu0.19.04.2~cloud0                amd64        distributed storage and file system
ii  ceph-base                      13.2.6-0ubuntu0.19.04.2~cloud0                amd64        common ceph daemon libraries and management tools
ii  ceph-common                    13.2.6-0ubuntu0.19.04.2~cloud0                amd64        common utilities to mount and interact with a ceph storage cluster
ii  ceph-mgr                       13.2.6-0ubuntu0.19.04.2~cloud0                amd64        manager for the ceph distributed file system
ii  ceph-mon                       13.2.6-0ubuntu0.19.04.2~cloud0                amd64        monitor server for the ceph storage system
ii  ceph-osd                       13.2.6-0ubuntu0.19.04.2~cloud0                amd64        OSD server for the ceph storage system
ii  libcephfs2                     13.2.6-0ubuntu0.19.04.2~cloud0                amd64        Ceph distributed file system client library
ii  python3-cephfs                 13.2.6-0ubuntu0.19.04.2~cloud0                amd64        Python 3 libraries for the Ceph libcephfs library

No more crash invalid syntax errors in /var/log/ceph/* either.

** Tags removed: verification-stein-needed
** Tags added: verification-stein-done

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1835354

Title:
  disco: ceph-mgr unable to load crash module under py3

Status in Ubuntu Cloud Archive:
  Fix Committed
Status in Ubuntu Cloud Archive stein series:
  Fix Committed
Status in Ubuntu Cloud Archive train series:
  Fix Released
Status in ceph package in Ubuntu:
  Fix Released
Status in ceph source package in Disco:
  Fix Committed
Status in ceph source package in Eoan:
  Fix Released

Bug description:
  [Impact]
  ceph-mgr daemon is unable to load the crash module due.

  [Test Case]
  Deploy ceph
  Check ceph-mgr log file
  Syntax error will be seen

  [Regression Potential]
  Minimal; python 3 syntax changes are well understood and this fix is already in the newer ceph release in eoan.

  [Original Bug Report]
  On startup the ceph-mgr daemon fails to load the crash module due to invalid Python 3 syntax:

  2019-07-04 04:11:54.533 7f1af75ab300  1 mgr[py] Loading python module 'crash'
  2019-07-04 04:11:54.605 7f1af75ab300 -1 mgr[py] Module not found: 'crash'
  2019-07-04 04:11:54.605 7f1af75ab300 -1 mgr[py] Traceback (most recent call last):

    File "/usr/lib/x86_64-linux-gnu/ceph/mgr/crash/__init__.py", line 1, in <module>
      from .module import Module
    File "/usr/lib/x86_64-linux-gnu/ceph/mgr/crash/module.py", line 48
      def inner((_, meta)):
                ^
  SyntaxError: invalid syntax

  Looking at the history for this module there are a number of
  syntax/compat fixes for Python3:

  https://github.com/ceph/ceph/commit/9aa1d49583ae8fb658967c054247cac6ec2125ab#diff-9433ab33e8bbf1048734205a3a1141ed
  https://github.com/ceph/ceph/commit/bcf0f4df2db8b51c58e5ca4d411d05e2a4d081ab#diff-9433ab33e8bbf1048734205a3a1141ed
  https://github.com/ceph/ceph/commit/6dc95544512362c202535139c323717ec867e20b#diff-9433ab33e8bbf1048734205a3a1141ed

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1835354/+subscriptions