[Bug 1800601] Re: [SRU] Infinite recursion in Python 3

[OpenStack Infra]

Reviewed:  https://review.openstack.org/616639
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=2bcd6c66629a06afdfcd32ff7892c5571bbe0573
Submitter: Zuul
Branch:    stable/rocky

commit 2bcd6c66629a06afdfcd32ff7892c5571bbe0573
Author: James Page <james.page at ubuntu.com>
Date:   Fri Nov 2 10:10:49 2018 +0000

    py3: fix recursion issue under py37
    
    Add tox target and resolve issue with infinite recursion in
    ExtraProperties class by directly using methods on the dict
    class.
    
    Closes-Bug: 1800601
    
    Change-Id: Ie98c4287c8bd1c364655adb99c7a88d1d451496e
    (cherry picked from commit 43587fb93d8d949d9a9895153ac06ea4e7e6d150)


** Tags added: in-stable-rocky

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1800601

Title:
  [SRU] Infinite recursion in Python 3

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive rocky series:
  Fix Released
Status in Glance:
  Fix Released
Status in glance package in Ubuntu:
  Fix Released
Status in glance source package in Cosmic:
  Fix Released
Status in glance source package in Disco:
  Fix Released

Bug description:
  Hi,

  When running unit tests under Python 3.7 when building the Rocky
  Debian package in Sid, I get a never ending recursion. Please see the
  Debian bug report:

  https://bugs.debian.org/911947

  Basically, it's this:

  |   File "/build/1st/glance-17.0.0/glance/domain/__init__.py", line 316, in keys
  |     return dict(self).keys()
  |   File "/build/1st/glance-17.0.0/glance/domain/__init__.py", line 316, in keys
  |     return dict(self).keys()
  |   File "/build/1st/glance-17.0.0/glance/domain/__init__.py", line 316, in keys
  |     return dict(self).keys()
  | RecursionError: maximum recursion depth exceeded while calling a Python object

  == Ubuntu SRU details ==

  [Impact]
  An infinite recursion error occurs when running Python 3.6 glance from rocky. This issue has also been seen when running python 3.7 unit tests.
  The error has also been seen in a Rocky deployment and causes the glance api service to return 500 errors.

  [Test Case]
  Bionic (cloud-archive): Deploy the glance charm on bionic then upgrade it to rocky by updating the openstack-origin to cloud:bionic-rocky/proposed
  Cosmic: Note that for cosmic we don't have the ability to test an upgrade from queens to rocky like we can on bionic so we'll just manually test the python3 code.

  [Regression Potential]
  Fairly low. The patch is a minimal fix and will be fully exercised by the OpenStack charms team.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1800601/+subscriptions