[Bug 1840347] Re: Ceph 12.2.12 restarts services during upgrade

[Eric Desrochers]

Ok the change works as expected:

# Before the upgrade : 12.2.12-0ubuntu0.18.04.1
root        4019       1  0 17:45 ?        00:00:00 bash /lib/systemd/system/jujud-unit-ceph-osd-1/exec-start.sh
root        4033    4019  0 17:45 ?        00:00:04 /var/lib/juju/tools/unit-ceph-osd-1/jujud unit --data-dir /var/lib/juju --unit-name ceph-osd/1 --debug
ceph       15176       1  0 17:57 ?        00:00:59 /usr/bin/ceph-osd -f --cluster ceph --id 1 --setuser ceph --setgroup ceph
root       25813    4033 50 22:58 ?        00:00:02 python3 /var/lib/juju/agents/unit-ceph-osd-1/charm/hooks/update-status
ubuntu     25910   25782  0 22:58 pts/0    00:00:00 grep --color=auto -i ceph-osd

# After the upgrade: 12.2.12-0ubuntu0.18.04.2 # ==> It's a test pkg (not in the archive yet)
root        4019       1  0 17:45 ?        00:00:00 bash /lib/systemd/system/jujud-unit-ceph-osd-1/exec-start.sh
root        4033    4019  0 17:45 ?        00:00:04 /var/lib/juju/tools/unit-ceph-osd-1/jujud unit --data-dir /var/lib/juju --unit-name ceph-osd/1 --debug
ceph       15176       1  0 17:57 ?        00:01:00 /usr/bin/ceph-osd -f --cluster ceph --id 1 --setuser ceph --setgroup ceph
root       28926   26301  0 23:01 pts/0    00:00:00 grep --color=auto -i ceph

I'll submit the MP to Cloud team for approval by end of week.

- Eric

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph in Ubuntu.
https://bugs.launchpad.net/bugs/1840347

Title:
  Ceph 12.2.12  restarts services during upgrade

Status in ceph package in Ubuntu:
  In Progress
Status in ceph source package in Bionic:
  In Progress
Status in ceph source package in Disco:
  In Progress
Status in ceph source package in Eoan:
  In Progress

Bug description:
  [Impact]

  Upgrading from ceph on Ubuntu 18.04 causes the ceph-osd services to be
  restarted without prompting.

  This appears to be in the configure section on the ceph-common,postinst:
  # Automatically added by dh_systemd_start/11.1.6ubuntu2
  if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
          if [ -d /run/systemd/system ]; then
                  systemctl --system daemon-reload >/dev/null || true
                  if [ -n "$2" ]; then
                          _dh_action=restart
                  else
                          _dh_action=start
                  fi
                  deb-systemd-invoke $_dh_action 'ceph.target' >/dev/null || true
          fi
  fi
  # End automatically added section

  This is a change of behaviour compare to debhelper 9.
  --restart-after-upgrade is the default in compat 10.

  The expected behavior during a package upgrade is to leave all the
  ceph service states unmodified. They should not be enabled/disabled or
  stopped/started.

  [Test Case]
  * Check pid of ceph-osd (before upgrade)
  * sudo apt-get update
  * sudo apt-get upgrade
  * Check pid of ceph-osd (after upgrade)

  If the pid changes, it means ceph-osd has been restarted, and the
  restart or stop/start has been exercised.

  [Potential Regression]

  Low, the desire is to control the precise timing of the restart.

  The larger context is that there may multiple updates (in this case
  kernel) and one want a single stop/start when the reboot occurred.

  The goal is for the admin to choose when (and which) ceph services
  move to the new code level.

  [Other Information]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1840347/+subscriptions