[Bug 1840347] Re: Ceph 12.2.12 restarts services during upgrade

[Eric Desrochers]

** Description changed:

- Upgrading from 12.2.11-0ubuntu0.18.04.2 to 12.2.12-0ubuntu0.18.04.1 on
- Ubuntu 18.04 causes the ceph-osd services to be restarted without
- prompting.
+ [Impact]
+ 
+ Upgrading from ceph on Ubuntu 18.04 causes the ceph-osd services to be
+ restarted without prompting.
  
  This appears to be in the configure section on the ceph-common,postinst:
  # Automatically added by dh_systemd_start/11.1.6ubuntu2
  if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
          if [ -d /run/systemd/system ]; then
                  systemctl --system daemon-reload >/dev/null || true
                  if [ -n "$2" ]; then
                          _dh_action=restart
                  else
                          _dh_action=start
                  fi
                  deb-systemd-invoke $_dh_action 'ceph.target' >/dev/null || true
          fi
  fi
  # End automatically added section
  
- dpkg.log after the upgrade shows that "configure" was exercised:
- 2019-08-15 10:49:18 upgrade ceph-common:amd64 12.2.11-0ubuntu0.18.04.2 12.2.12-
- ...
- 2019-08-15 10:49:29 configure ceph-common:amd64 12.2.12-0ubuntu0.18.04.1 <none>
- ..
- 2019-08-15 10:49:56 status installed ceph-common:amd64 12.2.12-0ubuntu0.18.04.1
+ This is a change of behaviour compare to debhelper 9. 
+ --restart-after-upgrade is the default in compat 10.
+ 
+ The expected behavior during a package upgrade is to leave all the ceph
+ service states unmodified. They should not be enabled/disabled or
+ stopped/started.
+ 
+ [Test Case]
+ * Check pid of ceph-osd (before upgrade)
+ * sudo apt-get update
+ * sudo apt-get upgrade
+ * Check pid of ceph-osd (after upgrade)
+ 
+ If the pid changes, it means ceph-osd has been restarted, and the
+ restart or stop/start has been exercised.
+ 
+ [Potential Regression]
+ 
+ [Other Informations]

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph in Ubuntu.
https://bugs.launchpad.net/bugs/1840347

Title:
  Ceph 12.2.12  restarts services during upgrade

Status in ceph package in Ubuntu:
  In Progress
Status in ceph source package in Bionic:
  In Progress
Status in ceph source package in Disco:
  In Progress
Status in ceph source package in Eoan:
  In Progress

Bug description:
  [Impact]

  Upgrading from ceph on Ubuntu 18.04 causes the ceph-osd services to be
  restarted without prompting.

  This appears to be in the configure section on the ceph-common,postinst:
  # Automatically added by dh_systemd_start/11.1.6ubuntu2
  if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
          if [ -d /run/systemd/system ]; then
                  systemctl --system daemon-reload >/dev/null || true
                  if [ -n "$2" ]; then
                          _dh_action=restart
                  else
                          _dh_action=start
                  fi
                  deb-systemd-invoke $_dh_action 'ceph.target' >/dev/null || true
          fi
  fi
  # End automatically added section

  This is a change of behaviour compare to debhelper 9. 
  --restart-after-upgrade is the default in compat 10.

  The expected behavior during a package upgrade is to leave all the
  ceph service states unmodified. They should not be enabled/disabled or
  stopped/started.

  [Test Case]
  * Check pid of ceph-osd (before upgrade)
  * sudo apt-get update
  * sudo apt-get upgrade
  * Check pid of ceph-osd (after upgrade)

  If the pid changes, it means ceph-osd has been restarted, and the
  restart or stop/start has been exercised.

  [Potential Regression]

  [Other Informations]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1840347/+subscriptions