[Bug 1840347] Re: Ceph 12.2.12 restarts services during upgrade

[Eric Desrochers]

By default compat 10

--restart-after-upgrade seems to be the default in compat 10.
Which explain why the behaviour observed are different between upstream (dh 9) & Ubuntu (dh 10)
(I build the Ubuntu ceph package with dh 9, and there is no trace of restart action)

It's definitely a change of behaviour cause with the introduction of dh
10 in the Ceph package.


* dh_systemd_start should be run after dh_installinit, as it is right now it is running inside dh_installinit.

* --no-restart-on-upgrade still works, but deprecated, to avoid
confusion a new alias has been created: --no-stop-on-upgrade

* I think the source package may need both : --no-stop-on-upgrade --no-
restart-after-upgrade in order to hopefully stop restarting.

This is where I am at the moment.

- Eric

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph in Ubuntu.
https://bugs.launchpad.net/bugs/1840347

Title:
  Ceph 12.2.12  restarts services during upgrade

Status in ceph package in Ubuntu:
  In Progress
Status in ceph source package in Bionic:
  In Progress
Status in ceph source package in Disco:
  In Progress
Status in ceph source package in Eoan:
  In Progress

Bug description:
  Upgrading from 12.2.11-0ubuntu0.18.04.2 to 12.2.12-0ubuntu0.18.04.1 on
  Ubuntu 18.04 causes the ceph-osd services to be restarted without
  prompting.

  This appears to be in the configure section on the ceph-common,postinst:
  # Automatically added by dh_systemd_start/11.1.6ubuntu2
  if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
          if [ -d /run/systemd/system ]; then
                  systemctl --system daemon-reload >/dev/null || true
                  if [ -n "$2" ]; then
                          _dh_action=restart
                  else
                          _dh_action=start
                  fi
                  deb-systemd-invoke $_dh_action 'ceph.target' >/dev/null || true
          fi
  fi
  # End automatically added section

  dpkg.log after the upgrade shows that "configure" was exercised:
  2019-08-15 10:49:18 upgrade ceph-common:amd64 12.2.11-0ubuntu0.18.04.2 12.2.12-
  ...
  2019-08-15 10:49:29 configure ceph-common:amd64 12.2.12-0ubuntu0.18.04.1 <none>
  ..
  2019-08-15 10:49:56 status installed ceph-common:amd64 12.2.12-0ubuntu0.18.04.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1840347/+subscriptions