[Bug 1793137] Related fix merged to charm-lxd (master)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/583499
Committed: https://git.openstack.org/cgit/openstack/charm-lxd/commit/?id=4d7b3e924008af878b0c369c1bd3e92238d51a93
Submitter: Zuul
Branch:    master

commit 4d7b3e924008af878b0c369c1bd3e92238d51a93
Author: Chris MacNaughton <chris.macnaughton at canonical.com>
Date:   Wed Jul 18 10:21:03 2018 +0200

    Remove old nova-compute / mysql relation and patch for nova-lxd bug
    
    This review is modified to include a patch to resolve bug #1793137
    which is due to a bug in nova-lxd where the wrong pool name (lxd) is
    used with zfs if lxd is new enough that the storage.zfs_pool_name key
    is missing from the config.  This is the case on bionic and snap
    installed lxd.
    
    Closes-Bug: #1713807
    Related-Bug: #1793137
    Change-Id: I1123d9882bdb00e9183424b363fc3d1ff25f2346

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1793137

Title:
  [SRU] Fix for KeyError: 'storage.zfs_pool_name' only partially
  successful -- needs changes

Status in OpenStack LXD Charm:
  In Progress
Status in Ubuntu Cloud Archive:
  Triaged
Status in Ubuntu Cloud Archive queens series:
  Triaged
Status in Ubuntu Cloud Archive rocky series:
  Triaged
Status in nova-lxd:
  New
Status in nova-lxd package in Ubuntu:
  Triaged
Status in nova-lxd source package in Bionic:
  Triaged
Status in nova-lxd source package in Cosmic:
  Triaged

Bug description:
  [Impact]

  The issue is that the fix was only partially successful, in that
  whilst it avoids the 'storage.zfs_pool_name', the other branch of code
  doesn't get the zfs pool name, but instead the lxd pool name; if they
  are different then it fails.

  The LXD charm used different names (it's now being patched to use the
  same name for the lxd pool and zfs pool), which broke nova-lxd on
  bionic.

  The code in question is in nova/virt/lxd/driver.py in
  get_available_resource(self, nodename) around line 1057:

              try:
                  pool_name = lxd_config['config']['storage.zfs_pool_name']
              except KeyError:
                  pool_name = CONF.lxd.pool
              local_disk_info = _get_zpool_info(pool_name)

  i.e. storage.zfs_pool_name vs CONF.lxd.pool

  When nova-lxd is properly refactored for storage pools, this issue
  should be resolved.

  
  [Test Case]

  
  [Regression Potential]

  
  [Discussion]

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-lxd/+bug/1793137/+subscriptions