[Bug 1793137] Re: Fix for KeyError: 'storage.zfs_pool_name' only partially successful -- needs changes

[Corey Bryant]

** Also affects: cloud-archive
   Importance: Undecided
       Status: New

** Also affects: cloud-archive/queens
   Importance: Undecided
       Status: New

** Also affects: cloud-archive/rocky
   Importance: Undecided
       Status: New

** Also affects: nova-lxd (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: nova-lxd (Ubuntu Cosmic)
   Importance: Undecided
       Status: New

** Also affects: nova-lxd (Ubuntu Bionic)
   Importance: Undecided
       Status: New

** Changed in: nova-lxd (Ubuntu Bionic)
       Status: New => Triaged

** Changed in: nova-lxd (Ubuntu Cosmic)
       Status: New => Triaged

** Changed in: cloud-archive/rocky
       Status: New => Triaged

** Changed in: cloud-archive/queens
       Status: New => Triaged

** Changed in: cloud-archive/queens
   Importance: Undecided => High

** Changed in: cloud-archive/rocky
   Importance: Undecided => High

** Changed in: nova-lxd (Ubuntu Bionic)
   Importance: Undecided => High

** Changed in: nova-lxd (Ubuntu Cosmic)
   Importance: Undecided => High

** Summary changed:

- Fix for KeyError: 'storage.zfs_pool_name' only partially successful -- needs changes
+ [SRU] Fix for KeyError: 'storage.zfs_pool_name' only partially successful -- needs changes

** Description changed:

+ [Impact]
+ 
  The issue is that the fix was only partially successful, in that whilst
  it avoids the 'storage.zfs_pool_name', the other branch of code doesn't
  get the zfs pool name, but instead the lxd pool name; if they are
  different then it fails.
  
  The LXD charm used different names (it's now being patched to use the
  same name for the lxd pool and zfs pool), which broke nova-lxd on
  bionic.
  
  The code in question is in nova/virt/lxd/driver.py in
  get_available_resource(self, nodename) around line 1057:
  
-             try:
-                 pool_name = lxd_config['config']['storage.zfs_pool_name']
-             except KeyError:
-                 pool_name = CONF.lxd.pool
-             local_disk_info = _get_zpool_info(pool_name)
+             try:
+                 pool_name = lxd_config['config']['storage.zfs_pool_name']
+             except KeyError:
+                 pool_name = CONF.lxd.pool
+             local_disk_info = _get_zpool_info(pool_name)
  
  i.e. storage.zfs_pool_name vs CONF.lxd.pool
  
  When nova-lxd is properly refactored for storage pools, this issue
  should be resolved.
+ 
+ 
+ [Test Case]
+ 
+ 
+ [Regression Potential]
+ 
+ 
+ [Discussion]

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1793137

Title:
  [SRU] Fix for KeyError: 'storage.zfs_pool_name' only partially
  successful -- needs changes

Status in OpenStack LXD Charm:
  In Progress
Status in Ubuntu Cloud Archive:
  Triaged
Status in Ubuntu Cloud Archive queens series:
  Triaged
Status in Ubuntu Cloud Archive rocky series:
  Triaged
Status in nova-lxd:
  New
Status in nova-lxd package in Ubuntu:
  Triaged
Status in nova-lxd source package in Bionic:
  Triaged
Status in nova-lxd source package in Cosmic:
  Triaged

Bug description:
  [Impact]

  The issue is that the fix was only partially successful, in that
  whilst it avoids the 'storage.zfs_pool_name', the other branch of code
  doesn't get the zfs pool name, but instead the lxd pool name; if they
  are different then it fails.

  The LXD charm used different names (it's now being patched to use the
  same name for the lxd pool and zfs pool), which broke nova-lxd on
  bionic.

  The code in question is in nova/virt/lxd/driver.py in
  get_available_resource(self, nodename) around line 1057:

              try:
                  pool_name = lxd_config['config']['storage.zfs_pool_name']
              except KeyError:
                  pool_name = CONF.lxd.pool
              local_disk_info = _get_zpool_info(pool_name)

  i.e. storage.zfs_pool_name vs CONF.lxd.pool

  When nova-lxd is properly refactored for storage pools, this issue
  should be resolved.

  
  [Test Case]

  
  [Regression Potential]

  
  [Discussion]

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-lxd/+bug/1793137/+subscriptions