[Bug 1778771] Fix merged to horizon (stable/pike)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/606052
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=02e405dcac62a08b1029af730881036554d971dd
Submitter: Zuul
Branch:    stable/pike

commit 02e405dcac62a08b1029af730881036554d971dd
Author: Edward Hope-Morley <edward.hope-morley at canonical.com>
Date:   Wed Sep 26 15:36:03 2018 +0100

    Add enabled check in Backups panel
    
    If enable_backup is False in OPENSTACK_CINDER_FEATURES
    then we should not display the backups panel.
    
    Change-Id: I276eebf0f11406bf354f5d8bbecef7b244d6d340
    Closes-Bug: #1778771
    (cherry picked from commit 6c2225bab8b007023e031d829bc72e8e50e6f1df)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1778771

Title:
  Backups panel is visible even if enable_backup is False

Status in OpenStack openstack-dashboard charm:
  Invalid
Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive queens series:
  Fix Committed
Status in Ubuntu Cloud Archive rocky series:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Fix Released
Status in horizon source package in Bionic:
  Triaged
Status in horizon source package in Cosmic:
  Fix Released

Bug description:
  Hi,

  Volumes - Backup panel is visible even if OPENSTACK_CINDER_FEATURES =
  {'enable_backup': False} in local_settings.py

  Meanwhile setting enable_backup to false removes an option to create
  backup of a volume in the volume drop-down options. But panel with
  backups itself stays visible for both admins and users.

  As a work-around I use the following customization script:
  import horizon
  from django.conf import settings
  if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False):
      project = horizon.get_dashboard("project")
      backup = project.get_panel("backups")
      project.unregister(backup.__class__)

  And for permanent fix I see the following decision. In openstack_dashboard/dashboards/project/backups/panel.py make the following changes:
  ...
  +L16: from django.conf import settings
  ...
  +L21:     if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False):
  +L22:         return False
  ...

  == SRU details for Ubuntu =

  [Impact]
  See above.

  [Test Case]
  Juju deploy openstack and manually test that backup panel is not visible if enable_backup is set to False.

  [Regression Potential]
  Low. The patch has landed upstream in master and stable/rocky and has received +2 for stable/queens. This patch has already landed in Ubuntu rocky as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1778771/+subscriptions