[Bug 1778771] Please test proposed package

[Corey Bryant]

Hello Dmitriy, or anyone else affected,

Accepted horizon into queens-proposed. The package will build now and be
available in the Ubuntu Cloud Archive in a few hours, and then in the
-proposed repository.

Please help us by testing this new package. To enable the -proposed
repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-queens-needed to verification-queens-done. If it does
not fix the bug for you, please add a comment stating that, and change
the tag to verification-queens-failed. In either case, details of your
testing will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
advance!

** Tags added: verification-queens-needed

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1778771

Title:
  Backups panel is visible even if enable_backup is False

Status in OpenStack openstack-dashboard charm:
  Invalid
Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive queens series:
  Fix Committed
Status in Ubuntu Cloud Archive rocky series:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Fix Released
Status in horizon source package in Bionic:
  Fix Released
Status in horizon source package in Cosmic:
  Fix Released

Bug description:
  Hi,

  Volumes - Backup panel is visible even if OPENSTACK_CINDER_FEATURES =
  {'enable_backup': False} in local_settings.py

  Meanwhile setting enable_backup to false removes an option to create
  backup of a volume in the volume drop-down options. But panel with
  backups itself stays visible for both admins and users.

  As a work-around I use the following customization script:
  import horizon
  from django.conf import settings
  if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False):
      project = horizon.get_dashboard("project")
      backup = project.get_panel("backups")
      project.unregister(backup.__class__)

  And for permanent fix I see the following decision. In openstack_dashboard/dashboards/project/backups/panel.py make the following changes:
  ...
  +L16: from django.conf import settings
  ...
  +L21:     if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False):
  +L22:         return False
  ...

  == SRU details for Ubuntu =

  [Impact]
  See above.

  [Test Case]
  Juju deploy openstack and manually test that backup panel is not visible if enable_backup is set to False.

  [Regression Potential]
  Low. The patch has landed upstream in master, stable/rocky, and stable/queens. This patch has already landed in Ubuntu rocky as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1778771/+subscriptions