[Bug 1808168] Re: Neutron FWaaS panel missing from dashboard on Queens

[Łukasz Zemczak]

I looked at the neutron-fwaas-dashboard package in the xenial NEW queue
and I have some question. There are obviously some differences between
1.3.0 in cosmic and the one backported to bionic. This makes the review
a bit less straightforward as our regular SRU NEW package-backport
policies do not apply.

The most obvious changes are the ones from py3 -> py2 which has been
explained in this bug, so I'll skip that part. There are some others
that I'd first want to know some about .

1) I noticed that in the cosmic package the tests were ran during
override_dh_install (which did seem a bit strange to me) but now have
moved to the proper place in override_dh_auto_test. What was the reason
that it was previously done at a different step?

2) In the original cosmic package, in override_dh_install I see that
some static files were being copied over to /usr/share/openstack-
dashboard/openstack_dashboard/static etc. which is not happening anymore
in the bionic backport. Everything else moved to
override_dh_auto_install. Are those now installed as part of pkgos-
dh_auto_install ? Why did the installation stages move so much?

3) This is a minor question (out of curiosity), just wanted to get some
context on this: why is 1.3.0 backported instead of 1.5.0? Not a problem
of course.

Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1808168

Title:
  Neutron FWaaS panel missing from dashboard on Queens

Status in OpenStack openstack-dashboard charm:
  In Progress
Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive queens series:
  In Progress
Status in Ubuntu Cloud Archive rocky series:
  Fix Released
Status in Ubuntu Cloud Archive stein series:
  Fix Released
Status in Ubuntu:
  Fix Released
Status in The Bionic Beaver:
  In Progress
Status in The Cosmic Cuttlefish:
  Fix Released
Status in The Disco Dingo:
  Fix Released

Bug description:
  [Impact]
  FwaaS functionality is not accessible from the OpenStack Dashboard

  [Test Case]
  Deploy Queens based OpenStack Cloud (using charms + juju).
  OpenStack dashboard does not have Project->Network->Firewall navigation and associate functionality

  [Regression Potential]
  Low; this is a new leaf package that adds to the function of the openstack-dashboard package.  Equivalent package is found in >= Cosmic.

  [Original Bug Report]
  Xenial + Queens.

  The FWaaS GUI panel is missing even if the service it's enabled and
  the Neutron extension is there:

  neutron ext-list|grep fwaas

  | fwaasrouterinsertion      | FWaaS Router Insertion                                                                       |
  | fwaas                     | FWaaS v1                                                                                     |

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1808168/+subscriptions