[Bug 1707103] Re: Useless line of code in shell.py

OpenStack Infra 1707103 at bugs.launchpad.net
Mon Sep 18 04:03:22 UTC 2017


Reviewed:  https://review.openstack.org/501966
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=61025bf1023328893904c3cc00bea28a238be544
Submitter: Jenkins
Branch:    master

commit 61025bf1023328893904c3cc00bea28a238be544
Author: Huan Xiong <huan.xiong at hxt-semitech.com>
Date:   Fri Sep 8 06:28:15 2017 +0000

    Useless line of code in shell.py
    
    Shell.py contains lines to import osprofiler. This is useless
    because osprofiler options support code was moved to osc-lib.
    
    Removed it.
    
    Change-Id: Ibec17700c87df908640848c3787d190ca66a7bcf
    Closes-Bug: #1707103


** Changed in: python-openstackclient
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to python-openstackclient in Ubuntu.
https://bugs.launchpad.net/bugs/1707103

Title:
  Useless line of code in shell.py

Status in python-openstackclient:
  Fix Released
Status in python-openstackclient package in Ubuntu:
  New

Bug description:
  This line in shell.py is useless:

    osprofiler_profiler = importutils.try_import("osprofiler.profiler")

  It was introduced in commit 16f00833 where it was useful. Most code in
  that commit was later moved to osc-lib in commit 6a15f90d. However,
  the above line was left uncleaned up.

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-openstackclient/+bug/1707103/+subscriptions



More information about the Ubuntu-openstack-bugs mailing list